address feedback

QxBytes · QxBytes · commit c015a0f34ae7 · 2025-05-09T12:55:44.000-07:00
diff --git a/store/json.go b/store/json.go
@@ -246,6 +246,7 @@ func (kvs *jsonFileStore) Remove() {
 	kvs.Mutex.Unlock()
 }
 
+// Dump returns the contents of the store in string format, erroring if it could not be read
 func (kvs *jsonFileStore) Dump() (string, error) {
 	kvs.Mutex.Lock()
 	defer kvs.Mutex.Unlock()
diff --git a/store/json_test.go b/store/json_test.go
@@ -134,7 +134,7 @@ func TestKeyValuePairsAreWrittenAndReadCorrectly(t *testing.T) {
 	// Dump empty store.
 	_, err = kvs.Dump()
 	if err == nil {
-		t.Fatal("Expected store to be empty")
+		t.Fatal("Expected store to not exist")
 	}
 
 	// Write a key value pair.

Original file line number	Diff line number	Diff line change
`@@ -246,6 +246,7 @@ func (kvs *jsonFileStore) Remove() {`
`246`	`246`	`kvs.Mutex.Unlock()`
`247`	`247`	`}`
`248`	`248`
	`249`	`+// Dump returns the contents of the store in string format, erroring if it could not be read`
`249`	`250`	`func (kvs *jsonFileStore) Dump() (string, error) {`
`250`	`251`	`kvs.Mutex.Lock()`
`251`	`252`	`defer kvs.Mutex.Unlock()`
Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ func TestKeyValuePairsAreWrittenAndReadCorrectly(t *testing.T) {`
`134`	`134`	`// Dump empty store.`
`135`	`135`	`_, err = kvs.Dump()`
`136`	`136`	`if err == nil {`
`137`		`- t.Fatal("Expected store to be empty")`
	`137`	`+ t.Fatal("Expected store to not exist")`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`// Write a key value pair.`