Make BYO CNI script universal to support multiple scenarios

Co-authored-by: camrynl <[email protected]>

Author: Copilot

hack/aks/README-byocilium.md renamed to hack/aks/README-byocni.md

@@ -1,10 +1,10 @@
-# BYO Cilium Cluster Setup Script
+# BYO CNI Cluster Setup Script
 
-The `create-byocilium-cluster.sh` script automates the creation of a BYO (Bring Your Own) Cilium cluster on Azure Kubernetes Service (AKS). It orchestrates the following steps:
+The `create-byocni-cluster.sh` script automates the creation of a BYO (Bring Your Own) CNI cluster on Azure Kubernetes Service (AKS). It orchestrates the following steps:
 
-1. **Cluster Creation**: Creates an AKS cluster with overlay networking and no kube-proxy using the `overlay-byocni-nokubeproxy-up` make target
-2. **CNS Deployment**: Deploys Azure Container Networking Service (CNS) to the cluster using the `test-load` make command
-3. **Cilium Installation**: Installs Cilium networking components using manifests from the `test/integration/manifests/cilium/` directory
+1. **Cluster Creation**: Creates an AKS cluster with configurable networking modes (overlay, swift, nodesubnet, dualstack-overlay, vnetscale-swift)
+2. **CNS Deployment**: Deploys Azure Container Networking Service (CNS) to the cluster using the `test-load` make command  
+3. **CNI Installation**: Installs the specified CNI networking components (Cilium by default, Azure CNI Manager, or none)
 
 ## Prerequisites
 
@@ -20,18 +20,20 @@ Before running the script, ensure you have:
 
 ### Basic Usage
 
-Create a cluster with default settings:
+Create a cluster with default settings (overlay networking with Cilium):
 ```bash
-./create-byocilium-cluster.sh --subscription YOUR_SUBSCRIPTION_ID
+./create-byocni-cluster.sh --subscription YOUR_SUBSCRIPTION_ID
 ```
 
 ### Advanced Usage
 
 Create a cluster with custom configuration:
 ```bash
-./create-byocilium-cluster.sh \
-    --cluster my-cilium-cluster \
+./create-byocni-cluster.sh \
+    --cluster my-cluster \
     --subscription YOUR_SUBSCRIPTION_ID \
+    --networking-mode swift \
+    --cni-plugin cilium \
     --cns-version v1.6.0 \
     --cilium-dir 1.16 \
     --cilium-version-tag v1.16.5
@@ -41,7 +43,7 @@ Create a cluster with custom configuration:
 
 Preview the commands that would be executed without actually running them:
 ```bash
-./create-byocilium-cluster.sh --subscription YOUR_SUBSCRIPTION_ID --dry-run
+./create-byocni-cluster.sh --subscription YOUR_SUBSCRIPTION_ID --dry-run
 ```
 
 ## Configuration Options
@@ -51,6 +53,10 @@ Preview the commands that would be executed without actually running them:
 | `--cluster` | Name of the AKS cluster | `byocni-cluster` |
 | `--subscription` | Azure subscription ID | *Required* |
 | `--azcli` | Azure CLI command | `az` |
+| `--networking-mode` | Networking mode (overlay, swift, nodesubnet, dualstack-overlay, vnetscale-swift) | `overlay` |
+| `--no-kube-proxy` | Create cluster without kube-proxy | `true` |
+| `--with-kube-proxy` | Create cluster with kube-proxy | Overrides --no-kube-proxy |
+| `--cni-plugin` | CNI plugin (cilium, azure-cni, none) | `cilium` |
 | `--cns-version` | CNS version to deploy | `v1.5.38` |
 | `--azure-ipam-version` | Azure IPAM version | `v0.3.0` |
 | `--cilium-dir` | Cilium version directory | `1.14` |
@@ -60,9 +66,23 @@ Preview the commands that would be executed without actually running them:
 | `--cns-image-repo` | CNS image repository | `MCR` |
 | `--dry-run` | Show commands without executing | `false` |
 
+## Networking Modes
+
+- **overlay**: Standard overlay networking mode (supports kube-proxy and no-kube-proxy)
+- **swift**: SWIFT networking mode (supports kube-proxy and no-kube-proxy)
+- **nodesubnet**: NodeSubnet networking mode (only supports no-kube-proxy)
+- **dualstack-overlay**: Dualstack overlay networking mode (supports kube-proxy and no-kube-proxy)
+- **vnetscale-swift**: VNet Scale SWIFT networking mode (supports kube-proxy and no-kube-proxy)
+
+## CNI Plugins
+
+- **cilium**: Deploy Cilium CNI with configurable versions (default)
+- **azure-cni**: Deploy Azure CNI Manager
+- **none**: Deploy only cluster and CNS, no CNI plugin
+
 ## Supported Cilium Versions
 
-The script supports the following Cilium versions based on available manifests:
+The script supports the following Cilium versions based on available manifests (when using --cni-plugin cilium):
 - v1.12
 - v1.13
 - v1.14 (default)
@@ -71,31 +91,58 @@ The script supports the following Cilium versions based on available manifests:
 
 ## Examples
 
-### Example 1: Basic cluster creation
+### Example 1: Basic cluster creation with Cilium (default)
 ```bash
-./create-byocilium-cluster.sh --subscription 9b8218f9-902a-4d20-a65c-e98acec5362f
+./create-byocni-cluster.sh --subscription 9b8218f9-902a-4d20-a65c-e98acec5362f
+```
+
+### Example 2: Swift networking with Azure CNI Manager
+```bash
+./create-byocni-cluster.sh \
+    --subscription 9b8218f9-902a-4d20-a65c-e98acec5362f \
+    --networking-mode swift \
+    --cni-plugin azure-cni
 ```
 
-### Example 2: Custom cluster with specific CNS version
+### Example 3: Custom cluster with specific CNS version and Cilium
 ```bash
-./create-byocilium-cluster.sh \
-    --cluster production-cilium \
+./create-byocni-cluster.sh \
+    --cluster production-cluster \
     --subscription 9b8218f9-902a-4d20-a65c-e98acec5362f \
+    --networking-mode overlay \
     --cns-version v1.6.0 \
-    --azure-ipam-version v0.4.0
+    --azure-ipam-version v0.4.0 \
+    --cni-plugin cilium \
+    --cilium-dir 1.16
 ```
 
-### Example 3: Latest Cilium version
+### Example 4: Cluster with kube-proxy enabled
 ```bash
-./create-byocilium-cluster.sh \
+./create-byocni-cluster.sh \
     --subscription 9b8218f9-902a-4d20-a65c-e98acec5362f \
+    --networking-mode overlay \
+    --with-kube-proxy
+```
+
+### Example 5: Dualstack cluster with Cilium
+```bash
+./create-byocni-cluster.sh \
+    --subscription 9b8218f9-902a-4d20-a65c-e98acec5362f \
+    --networking-mode dualstack-overlay \
     --cilium-dir 1.17 \
     --cilium-version-tag v1.17.0
 ```
 
-### Example 4: Using different image registry
+### Example 6: Only cluster and CNS, no CNI plugin
+```bash
+./create-byocni-cluster.sh \
+    --subscription 9b8218f9-902a-4d20-a65c-e98acec5362f \
+    --cni-plugin none
+```
+
+### Example 7: Using different image registry
 ```bash
-./create-byocilium-cluster.sh \
+./create-byocni-cluster.sh \
     --subscription 9b8218f9-902a-4d20-a65c-e98acec5362f \
     --cilium-registry mcr.microsoft.com/containernetworking \
     --cilium-version-tag v1.14.8
@@ -134,7 +181,7 @@ After successful cluster creation, you can:
 
 Use the `--dry-run` flag to see exactly what commands would be executed:
 ```bash
-./create-byocilium-cluster.sh --subscription YOUR_SUBSCRIPTION_ID --dry-run
+./create-byocni-cluster.sh --subscription YOUR_SUBSCRIPTION_ID --dry-run
 ```
 
 Check the logs for detailed information about each step of the process.