feat: add and expose new ConfigSnapshotIntervalInMins config

Author: jackieluc

cns/configuration/cns_config.json

@@ -5,6 +5,7 @@
         "HeartBeatIntervalInMins": 30,
         "RefreshIntervalInSecs": 15,
         "SnapshotIntervalInMins": 60,
+        "ConfigSnapshotIntervalInMins": 60,
         "TelemetryBatchIntervalInSecs": 15,
         "TelemetryBatchSizeBytes": 16384
     },

cns/configuration/configuration.go

@@ -79,6 +79,8 @@ type TelemetrySettings struct {
 	DebugMode bool
 	// Interval for sending snapshot events.
 	SnapshotIntervalInMins int
+	// Interval for sending config snapshot events.
+	ConfigSnapshotIntervalInMins int
 	// AppInsightsInstrumentationKey allows the user to override the default appinsights ikey
 	AppInsightsInstrumentationKey string
 }
@@ -176,6 +178,10 @@ func setTelemetrySettingDefaults(telemetrySettings *TelemetrySettings) {
 	if telemetrySettings.SnapshotIntervalInMins == 0 {
 		telemetrySettings.SnapshotIntervalInMins = 60
 	}
+
+	if telemetrySettings.ConfigSnapshotIntervalInMins == 0 {
+		telemetrySettings.ConfigSnapshotIntervalInMins = 60
+	}
 }
 
 // set managed setting defaults

cns/configuration/configuration_test.go

@@ -80,6 +80,7 @@ func TestReadConfigFromFile(t *testing.T) {
 					HeartBeatIntervalInMins:      30,
 					RefreshIntervalInSecs:        15,
 					SnapshotIntervalInMins:       60,
+					ConfigSnapshotIntervalInMins: 60,
 					TelemetryBatchIntervalInSecs: 15,
 					TelemetryBatchSizeBytes:      16384,
 				},
@@ -122,6 +123,7 @@ func TestSetTelemetrySettingDefaults(t *testing.T) {
 				TelemetryBatchSizeBytes:      32768,
 				HeartBeatIntervalInMins:      30,
 				SnapshotIntervalInMins:       60,
+				ConfigSnapshotIntervalInMins: 60,
 			},
 		},
 		{
@@ -132,13 +134,15 @@ func TestSetTelemetrySettingDefaults(t *testing.T) {
 				TelemetryBatchSizeBytes:      5,
 				HeartBeatIntervalInMins:      6,
 				SnapshotIntervalInMins:       7,
+				ConfigSnapshotIntervalInMins: 8,
 			},
 			want: TelemetrySettings{
 				RefreshIntervalInSecs:        3,
 				TelemetryBatchIntervalInSecs: 4,
 				TelemetryBatchSizeBytes:      5,
 				HeartBeatIntervalInMins:      6,
 				SnapshotIntervalInMins:       7,
+				ConfigSnapshotIntervalInMins: 8,
 			},
 		},
 	}
@@ -206,6 +210,7 @@ func TestSetCNSConfigDefaults(t *testing.T) {
 					HeartBeatIntervalInMins:      30,
 					RefreshIntervalInSecs:        15,
 					SnapshotIntervalInMins:       60,
+					ConfigSnapshotIntervalInMins: 60,
 				},
 				KeyVaultSettings: KeyVaultSettings{
 					RefreshIntervalInHrs: 12,
@@ -238,6 +243,7 @@ func TestSetCNSConfigDefaults(t *testing.T) {
 					HeartBeatIntervalInMins:      3,
 					RefreshIntervalInSecs:        1,
 					SnapshotIntervalInMins:       6,
+					ConfigSnapshotIntervalInMins: 7,
 				},
 				KeyVaultSettings: KeyVaultSettings{
 					RefreshIntervalInHrs: 3,
@@ -265,6 +271,7 @@ func TestSetCNSConfigDefaults(t *testing.T) {
 					HeartBeatIntervalInMins:      3,
 					RefreshIntervalInSecs:        1,
 					SnapshotIntervalInMins:       6,
+					ConfigSnapshotIntervalInMins: 7,
 				},
 				KeyVaultSettings: KeyVaultSettings{
 					RefreshIntervalInHrs: 3,

cns/configuration/testdata/good.json

@@ -26,6 +26,7 @@
         "HeartBeatIntervalInMins": 30,
         "RefreshIntervalInSecs": 15,
         "SnapshotIntervalInMins": 60,
+        "ConfigSnapshotIntervalInMins": 60,
         "TelemetryBatchIntervalInSecs": 15,
         "TelemetryBatchSizeBytes": 16384
     },

cns/logger/constants.go

@@ -3,7 +3,8 @@ package logger
 
 const (
 	// Metrics
-	HeartBeatMetricStr = "HeartBeat"
+	HeartBeatMetricStr       = "HeartBeat"
+	ConfigSnapshotMetricsStr = "ConfigSnapshot"
 
 	// Dimensions
 	OrchestratorTypeStr = "OrchestratorType"
@@ -13,7 +14,7 @@ const (
 	HomeAZErrorCodeStr  = "HomeAZErrorCode"
 	HomeAZErrorMsgStr   = "HomeAZErrorMsg"
 
-	// CNS Snspshot properties
+	// CNS NC Snspshot properties
 	CnsNCSnapshotEventStr         = "CNSNCSnapshot"
 	IpConfigurationStr            = "IPConfiguration"
 	LocalIPConfigurationStr       = "LocalIPConfiguration"