make metrics recording async so that it will not block ip requests

Signed-off-by: Evan Baker <[email protected]>

Author: rbtr

cns/restserver/metrics.go

@@ -1,6 +1,7 @@
 package restserver
 
 import (
+	"context"
 	"maps"
 	"net/http"
 	"time"
@@ -124,7 +125,6 @@ func init() {
 // Every http response is 200 so we really want cns  response code.
 // Hard tto do with middleware unless we derserialize the responses but making it an explit header works around it.
 // if that doesn't work we could have a separate countervec just for response codes.
-
 func NewHandlerFuncWithHistogram(handler http.HandlerFunc, histogram *prometheus.HistogramVec) http.HandlerFunc {
 	return func(w http.ResponseWriter, req *http.Request) {
 		start := time.Now()
@@ -157,14 +157,30 @@ type ipState struct {
 	releasingIPs int64
 }
 
-// publishIPStateMetrics logs and publishes the IP Config state metrics to Prometheus.
-func (service *HTTPRestService) publishIPStateMetrics() {
-	// copy state
-	service.RLock()
-	defer service.RUnlock()
+type asyncMetricsRecorder struct {
+	podIPConfigSrc func() map[string]cns.IPConfigurationStatus
+	sig            chan struct{}
+}
+
+// singleton recorder
+var recorder *asyncMetricsRecorder
+
+// run starts the asyncMetricsRecorder and listens for signals to record the metrics.
+func (a asyncMetricsRecorder) run(ctx context.Context) {
+	for {
+		select {
+		case <-ctx.Done():
+			return
+		case <-a.sig:
+			a.record()
+		}
+	}
+}
 
+// record records the IP Config state metrics to Prometheus.
+func (a asyncMetricsRecorder) record() {
 	var state ipState
-	for ipConfig := range maps.Values(service.PodIPConfigState) {
+	for ipConfig := range maps.Values(a.podIPConfigSrc()) {
 		state.allocatedIPs++
 		if ipConfig.GetState() == types.Assigned {
 			state.assignedIPs++
@@ -195,3 +211,26 @@ func (service *HTTPRestService) publishIPStateMetrics() {
 	pendingProgrammingIPCount.WithLabelValues(labels...).Set(float64(state.programmingIPs))
 	pendingReleaseIPCount.WithLabelValues(labels...).Set(float64(state.releasingIPs))
 }
+
+// publishIPStateMetrics logs and publishes the IP Config state metrics to Prometheus.
+func (service *HTTPRestService) publishIPStateMetrics() {
+	if recorder == nil {
+		recorder = &asyncMetricsRecorder{
+			podIPConfigSrc: service.PodIPConfigStates,
+			sig:            make(chan struct{}),
+		}
+		go recorder.run(context.TODO())
+	}
+	select {
+	case recorder.sig <- struct{}{}: // signal the recorder to record the metrics
+	default: // drop the signal if the recorder already has an event queued
+	}
+}
+
+// PodIPConfigStates returns a clone of the IP Config State map.
+func (service *HTTPRestService) PodIPConfigStates() map[string]cns.IPConfigurationStatus {
+	// copy state
+	service.RLock()
+	defer service.RUnlock()
+	return maps.Clone(service.PodIPConfigState)
+}