bump to go v1.24

Author: nddq

.devcontainer/Dockerfile

@@ -1,7 +1,7 @@
 # See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.203.0/containers/go/.devcontainer/base.Dockerfile
 
 # [Choice] Go version (use -bullseye variants on local arm64/Apple Silicon): 1, 1.16, 1.17, 1-bullseye, 1.16-bullseye, 1.17-bullseye, 1-buster, 1.16-buster, 1.17-buster
-ARG VARIANT="1.22"
+ARG VARIANT="dev-1.24"
 FROM mcr.microsoft.com/vscode/devcontainers/go:${VARIANT}
 
 # [Choice] Node.js version: none, lts/*, 16, 14, 12, 10

.devcontainer/devcontainer.json

@@ -8,7 +8,7 @@
 			// Update the VARIANT arg to pick a version of Go: 1, 1.16, 1.17
 			// Append -bullseye or -buster to pin to an OS version.
 			// Use -bullseye variants on local arm64/Apple Silicon.
-			"VARIANT": "1.22-bullseye",
+			"VARIANT": "dev-1.24",
 			// Options
 			"NODE_VERSION": "none"
 		}

.github/dependabot.yaml

@@ -47,17 +47,6 @@ updates:
     - "azure/azure-sdn-members"
   commit-message:
     prefix: "deps"
-- package-ecosystem: "gomod"
-  directory: "/build/tools"
-  schedule:
-    interval: "daily"
-  assignees:
-    - "matmerr"
-    - "rbtr"
-  reviewers:
-    - "azure/azure-sdn-members"
-  commit-message:
-    prefix: "deps"
 - package-ecosystem: "gomod"
   directory: "/dropgz"
   schedule:

.github/workflows/crdgen.yaml

@@ -8,20 +8,16 @@ on:
       - synchronize
       - ready_for_review
 jobs:
-  crdgen119:
-    strategy:
-      matrix:
-        go-version: ["1.23", "1.24"]
-        os: [ubuntu-latest]
+  crdgen:
     name: CRDs are Generated
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - uses: actions/setup-go@v5
         with:
-          go-version: ${{ matrix.go-version }}
+          go-version: stable
       - name: Regenerate NodeNetworkConfig CRD
         run: make -C crd/nodenetworkconfig
       - name: Regenerate MultitenantNetworkContainer CRD

.github/workflows/cyclonus-netpol-extended-nightly-test.yaml

@@ -27,7 +27,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: "^1.22"
+          go-version: stable
 
       - name: Setup Kind
         uses: engineerd/[email protected]

.github/workflows/cyclonus-netpol-test.yaml

@@ -34,7 +34,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: '^1.23'
+          go-version: stable
 
       - name: Setup Kind
         uses: helm/kind-action@v1

.github/workflows/golangci.yaml

@@ -15,19 +15,18 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        go-version: ['1.23.x', '1.24.x']
         os: [ubuntu-latest, windows-latest]
     name: Lint
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/setup-go@v5
       with:
-        go-version: ${{ matrix.go-version }}
+        go-version: stable
     - uses: actions/checkout@v4
       with:
         fetch-depth: 0
     - name: golangci-lint
       uses: golangci/golangci-lint-action@v6
       with:
-        version: v1.61
+        version: latest
         args: --new-from-rev=origin/release/v1.4 --config=.golangci.yml --timeout=25m 

.gitignore

@@ -22,7 +22,6 @@ ipam-*.xml
 *.test
 
 controller-gen
-build/tools/bin
 npm/debug/http
 
 # certificates

.pipelines/pipeline.yaml

@@ -68,7 +68,7 @@ stages:
               { { { {
                     sudo -E env "PATH=$PATH" make test-all;
                     echo $? >&3;
-                    } | tee >(build/tools/bin/go-junit-report > report.xml) >&4;
+                    } | tee >(go tool go-junit-report > report.xml) >&4;
                   } 3>&1;
                 } | { read xs; exit $xs; }
               } 4>&1

Makefile

@@ -65,8 +65,6 @@ CNI_OVERLAY_BUILD_DIR = $(BUILD_DIR)/cni-overlay
 CNI_BAREMETAL_BUILD_DIR = $(BUILD_DIR)/cni-baremetal
 CNS_BUILD_DIR = $(BUILD_DIR)/cns
 NPM_BUILD_DIR = $(BUILD_DIR)/npm
-TOOLS_DIR = $(REPO_ROOT)/build/tools
-TOOLS_BIN_DIR = $(TOOLS_DIR)/bin
 CNI_AI_ID = 5515a1eb-b2bc-406a-98eb-ba462e6f0411
 CNS_AI_ID = ce672799-8f08-4235-8c12-08563dc2acef
 NPM_AI_ID = 014c22bd-4107-459e-8475-67909e96edcb
@@ -75,15 +73,6 @@ CNI_AI_PATH=$(ACN_PACKAGE_PATH)/telemetry.aiMetadata
 CNS_AI_PATH=$(ACN_PACKAGE_PATH)/cns/logger.aiMetadata
 NPM_AI_PATH=$(ACN_PACKAGE_PATH)/npm.aiMetadata
 
-# Tool paths
-CONTROLLER_GEN  := $(TOOLS_BIN_DIR)/controller-gen
-GOCOV           := $(TOOLS_BIN_DIR)/gocov
-GOCOV_XML       := $(TOOLS_BIN_DIR)/gocov-xml
-GOFUMPT         := $(TOOLS_BIN_DIR)/gofumpt
-GOLANGCI_LINT   := $(TOOLS_BIN_DIR)/golangci-lint
-GO_JUNIT_REPORT := $(TOOLS_BIN_DIR)/go-junit-report
-MOCKGEN         := $(TOOLS_BIN_DIR)/mockgen
-
 # Archive file names.
 ACNCLI_ARCHIVE_NAME = acncli-$(GOOS)-$(GOARCH)-$(ACN_VERSION).$(ARCHIVE_EXT)
 CNI_ARCHIVE_NAME = azure-vnet-cni-$(GOOS)-$(GOARCH)-$(CNI_VERSION).$(ARCHIVE_EXT)
@@ -680,16 +669,17 @@ endif
 
 clean: ## Clean build artifacts.
 	$(RMDIR) $(OUTPUT_DIR)
-	$(RMDIR) $(TOOLS_BIN_DIR)
 	$(RMDIR) go.work*
 
 
 LINT_PKG ?= .
 
-lint: $(GOLANGCI_LINT) ## Fast lint vs default branch showing only new issues.
+GOLANGCI_LINT = go tool golangci-lint
+
+lint: ## Fast lint vs default branch showing only new issues.
 	GOGC=20 $(GOLANGCI_LINT) run --new-from-rev release/v1.4 --timeout 10m -v $(LINT_PKG)/...
 
-lint-all: $(GOLANGCI_LINT) ## Lint the current branch in entirety.
+lint-all: ## Lint the current branch in entirety.
 	GOGC=20 $(GOLANGCI_LINT) run -v $(LINT_PKG)/...
 
 
@@ -761,57 +751,7 @@ gitconfig: ## configure the local git repository
 	@git config core.fsmonitor true
 	@git config core.untrackedcache true
 
-setup: tools install-hooks gitconfig ## performs common required repo setup
-
-
-##@ Tools
-
-$(TOOLS_DIR)/go.mod:
-	cd $(TOOLS_DIR); go mod init && go mod tidy
-
-$(CONTROLLER_GEN): $(TOOLS_DIR)/go.mod
-	cd $(TOOLS_DIR); go mod download; go build -o bin/controller-gen sigs.k8s.io/controller-tools/cmd/controller-gen
-
-controller-gen: $(CONTROLLER_GEN) ## Build controller-gen
-
-protoc:
-	source ${REPO_ROOT}/scripts/install-protoc.sh
-
-$(GOCOV): $(TOOLS_DIR)/go.mod
-	cd $(TOOLS_DIR); go mod download; go build -o bin/gocov github.com/axw/gocov/gocov
-
-gocov: $(GOCOV) ## Build gocov
-
-$(GOCOV_XML): $(TOOLS_DIR)/go.mod
-	cd $(TOOLS_DIR); go mod download; go build -o bin/gocov-xml github.com/AlekSi/gocov-xml
-
-gocov-xml: $(GOCOV_XML) ## Build gocov-xml
-
-$(GOFUMPT): $(TOOLS_DIR)/go.mod
-	cd $(TOOLS_DIR); go mod download; go build -o bin/gofumpt mvdan.cc/gofumpt
-
-gofumpt: $(GOFUMPT) ## Build gofumpt
-
-$(GOLANGCI_LINT): $(TOOLS_DIR)/go.mod
-	cd $(TOOLS_DIR); go mod download; go build -o bin/golangci-lint github.com/golangci/golangci-lint/cmd/golangci-lint
-
-golangci-lint: $(GOLANGCI_LINT) ## Build golangci-lint
-
-$(GO_JUNIT_REPORT): $(TOOLS_DIR)/go.mod
-	cd $(TOOLS_DIR); go mod download; go build -o bin/go-junit-report github.com/jstemmer/go-junit-report
-
-go-junit-report: $(GO_JUNIT_REPORT) ## Build go-junit-report
-
-$(MOCKGEN): $(TOOLS_DIR)/go.mod
-	cd $(TOOLS_DIR); go mod download; go build -o bin/mockgen github.com/golang/mock/mockgen
-
-mockgen: $(MOCKGEN) ## Build mockgen
-
-clean-tools:
-	rm -r build/tools/bin
-
-tools: acncli gocov gocov-xml go-junit-report golangci-lint gofumpt protoc ## Build bins for build tools
-
+setup: install-hooks gitconfig ## performs common required repo setup
 
 ##@ Help