address feedback

Author: QxBytes

npm/pkg/dataplane/ipsets/ipsetmanager_windows_test.go

@@ -376,21 +376,23 @@ func TestFailureOnDeletion(t *testing.T) {
 	verifyDeletedHNSCache(t, toDeleteSetNames, hns)
 }
 
+// sorts the Values field of the hcn set policy setting and returns a copy with sorted values
+func getSortedHnsPolicySetting(setting *hcn.SetPolicySetting) hcn.SetPolicySetting {
+	members := strings.Split(setting.Values, ",")
+	sort.Strings(members)
+	copyOfSetting := *setting
+	copyOfSetting.Values = strings.Join(members, ",")
+	return copyOfSetting
+}
+
 func verifyHNSCache(t *testing.T, expected map[string]hcn.SetPolicySetting, hns *hnswrapper.Hnsv2wrapperFake) {
 	for setName, setObj := range expected {
 		cacheObj := hns.Cache.SetPolicy(setObj.Id)
 		require.NotNil(t, cacheObj)
 
 		// make values always sorted for testing consistency
-		members := strings.Split(cacheObj.Values, ",")
-		sort.Strings(members)
-		copyOfCachedObj := *cacheObj
-		copyOfCachedObj.Values = strings.Join(members, ",")
-
-		expectedMembers := strings.Split(setObj.Values, ",")
-		sort.Strings(expectedMembers)
-		copyOfExpectedObj := setObj
-		copyOfExpectedObj.Values = strings.Join(expectedMembers, ",")
+		copyOfCachedObj := getSortedHnsPolicySetting(cacheObj)
+		copyOfExpectedObj := getSortedHnsPolicySetting(&setObj)
 
 		require.Equal(t, copyOfExpectedObj, copyOfCachedObj, setName+" mismatch in cache")
 	}