added a default value for loglevel

rayaisaiah · rayaisaiah · commit d8ec874fa45a · 2025-03-06T00:46:47.000Z
diff --git a/npm/cmd/start.go b/npm/cmd/start.go
@@ -135,7 +135,11 @@ func start(config npmconfig.Config, flags npmconfig.Flags) error {
 		)
 	}
 
-	err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata(), config.LogLevel)
+	logLevel := config.LogLevel
+	if logLevel == "" {
+		logLevel = npmconfig.DefaultConfig.LogLevel
+	}
+	err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata(), logLevel)
 	if err != nil {
 		klog.Infof("CreateTelemetryHandle failed with error %v. AITelemetry is not initialized.", err)
 	}
diff --git a/npm/cmd/start_daemon.go b/npm/cmd/start_daemon.go
@@ -94,7 +94,11 @@ func startDaemon(config npmconfig.Config) error {
 		return fmt.Errorf("failed to create dataplane: %w", err)
 	}
 
-	err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata(), config.LogLevel)
+	logLevel := config.LogLevel
+	if logLevel == "" {
+		logLevel = npmconfig.DefaultConfig.LogLevel
+	}
+	err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata(), logLevel)
 	if err != nil {
 		klog.Infof("CreateTelemetryHandle failed with error %v. AITelemetry is not initialized.", err)
 	}
diff --git a/npm/cmd/start_server.go b/npm/cmd/start_server.go
@@ -113,7 +113,11 @@ func startControlplane(config npmconfig.Config, flags npmconfig.Flags) error {
 		return fmt.Errorf("failed to create NPM controlplane manager: %w", err)
 	}
 
-	err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata(), config.LogLevel)
+	logLevel := config.LogLevel
+	if logLevel == "" {
+		logLevel = npmconfig.DefaultConfig.LogLevel
+	}
+	err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata(), logLevel)
 	if err != nil {
 		klog.Infof("CreateTelemetryHandle failed with error %v. AITelemetry is not initialized.", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,11 @@ func start(config npmconfig.Config, flags npmconfig.Flags) error {`
`135`	`135`	`)`
`136`	`136`	`}`
`137`	`137`
`138`		`- err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata(), config.LogLevel)`
	`138`	`+ logLevel := config.LogLevel`
	`139`	`+ if logLevel == "" {`
	`140`	`+ logLevel = npmconfig.DefaultConfig.LogLevel`
	`141`	`+ }`
	`142`	`+ err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata(), logLevel)`
`139`	`143`	`if err != nil {`
`140`	`144`	`klog.Infof("CreateTelemetryHandle failed with error %v. AITelemetry is not initialized.", err)`
`141`	`145`	`}`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,11 @@ func startDaemon(config npmconfig.Config) error {`
`94`	`94`	`return fmt.Errorf("failed to create dataplane: %w", err)`
`95`	`95`	`}`
`96`	`96`
`97`		`- err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata(), config.LogLevel)`
	`97`	`+ logLevel := config.LogLevel`
	`98`	`+ if logLevel == "" {`
	`99`	`+ logLevel = npmconfig.DefaultConfig.LogLevel`
	`100`	`+ }`
	`101`	`+ err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata(), logLevel)`
`98`	`102`	`if err != nil {`
`99`	`103`	`klog.Infof("CreateTelemetryHandle failed with error %v. AITelemetry is not initialized.", err)`
`100`	`104`	`}`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,11 @@ func startControlplane(config npmconfig.Config, flags npmconfig.Flags) error {`
`113`	`113`	`return fmt.Errorf("failed to create NPM controlplane manager: %w", err)`
`114`	`114`	`}`
`115`	`115`
`116`		`- err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata(), config.LogLevel)`
	`116`	`+ logLevel := config.LogLevel`
	`117`	`+ if logLevel == "" {`
	`118`	`+ logLevel = npmconfig.DefaultConfig.LogLevel`
	`119`	`+ }`
	`120`	`+ err = metrics.CreateTelemetryHandle(config.NPMVersion(), version, npm.GetAIMetadata(), logLevel)`
`117`	`121`	`if err != nil {`
`118`	`122`	`klog.Infof("CreateTelemetryHandle failed with error %v. AITelemetry is not initialized.", err)`
`119`	`123`	`}`