add readyz and pprof listeners (#1395)

* add readyz and pprof listeners

Signed-off-by: Evan Baker <[email protected]>

* add more pprof handlers

Signed-off-by: Evan Baker <[email protected]>

Author: rbtr

cns/configuration/configuration.go

@@ -20,6 +20,7 @@ const (
 
 type CNSConfig struct {
 	ChannelMode                 string
+	EnablePprof                 bool
 	InitializeFromCNI           bool
 	ManagedSettings             ManagedSettings
 	MetricsBindAddress          string

cns/healthserver/server.go

@@ -6,21 +6,18 @@ import (
 	"github.com/labstack/echo/v4"
 	"github.com/prometheus/client_golang/prometheus/promhttp"
 	"go.uber.org/zap"
+	"sigs.k8s.io/controller-runtime/pkg/healthz"
 	"sigs.k8s.io/controller-runtime/pkg/metrics"
 )
 
 func Start(log *zap.Logger, addr string) {
 	e := echo.New()
 
-	e.GET("/healthz", healthz)
+	e.GET("/healthz", echo.WrapHandler(http.StripPrefix("/healthz", &healthz.Handler{})))
 	e.GET("/metrics", echo.WrapHandler(promhttp.HandlerFor(metrics.Registry, promhttp.HandlerOpts{
 		ErrorHandling: promhttp.HTTPErrorOnError,
 	})))
 	if err := e.Start(addr); err != nil {
 		log.Error("failed to run healthserver", zap.Error(err))
 	}
 }
-
-func healthz(c echo.Context) error {
-	return c.NoContent(http.StatusOK) //nolint:wrapcheck // ignore
-}

cns/service/main.go

@@ -9,6 +9,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
+	"net/http/pprof"
 	"os"
 	"os/signal"
 	"runtime"
@@ -55,6 +56,7 @@ import (
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/cache"
 	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/healthz"
 )
 
 const (
@@ -1040,6 +1042,24 @@ func InitializeCRDState(ctx context.Context, httpRestService cns.HTTPService, cn
 		return errors.Wrapf(err, "failed to setup reconciler with manager")
 	}
 
+	// adding some routes to the root service mux
+	mux := httpRestServiceImplementation.Listener.GetMux()
+	mux.Handle("/readyz", http.StripPrefix("/readyz", &healthz.Handler{}))
+	if cnsconfig.EnablePprof {
+		// add pprof endpoints
+		mux.Handle("/debug/pprof/allocs", pprof.Handler("allocs"))
+		mux.Handle("/debug/pprof/block", pprof.Handler("block"))
+		mux.Handle("/debug/pprof/goroutine", pprof.Handler("goroutine"))
+		mux.Handle("/debug/pprof/heap", pprof.Handler("heap"))
+		mux.Handle("/debug/pprof/mutex", pprof.Handler("mutex"))
+		mux.Handle("/debug/pprof/threadcreate", pprof.Handler("threadcreate"))
+		mux.HandleFunc("/debug/pprof/", pprof.Index)
+		mux.HandleFunc("/debug/pprof/cmdline", pprof.Cmdline)
+		mux.HandleFunc("/debug/pprof/profile", pprof.Profile)
+		mux.HandleFunc("/debug/pprof/symbol", pprof.Symbol)
+		mux.HandleFunc("/debug/pprof/trace", pprof.Trace)
+	}
+
 	// Start the Manager which starts the reconcile loop.
 	// The Reconciler will send an initial NodeNetworkConfig update to the PoolMonitor, starting the
 	// Monitor's internal loop.