Skip to content

Commit e497ec0

Browse files
rbtrbehzad-mir
authored andcommitted
fix: add OS=windows to manifest-add args (#2194)
due to a change in buildx, we need to explicitly pull the windows variant of the windows image that we have previously built. Signed-off-by: Evan Baker <[email protected]>
1 parent 3ad4c65 commit e497ec0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -493,14 +493,14 @@ manifest-create:
493493
$(CONTAINER_BUILDER) manifest create $(IMAGE_REGISTRY)/$(IMAGE):$(TAG)
494494

495495
manifest-add:
496-
$(CONTAINER_BUILDER) manifest add --os-version=$($(OS_VERSION)) $(IMAGE_REGISTRY)/$(IMAGE):$(TAG) docker://$(IMAGE_REGISTRY)/$(IMAGE):$(subst /,-,$(PLATFORM))$(if $(OS_VERSION),-$(OS_VERSION),)-$(TAG)
496+
$(CONTAINER_BUILDER) manifest add --os=$(OS) --os-version=$($(OS_VERSION)) $(IMAGE_REGISTRY)/$(IMAGE):$(TAG) docker://$(IMAGE_REGISTRY)/$(IMAGE):$(subst /,-,$(PLATFORM))$(if $(OS_VERSION),-$(OS_VERSION),)-$(TAG)
497497

498498
manifest-build: # util target to compose multiarch container manifests from platform specific images.
499499
$(MAKE) manifest-create
500500
$(foreach PLATFORM,$(PLATFORMS),\
501501
$(if $(filter $(PLATFORM),windows/amd64),\
502502
$(foreach OS_VERSION,$(OS_VERSIONS),\
503-
$(MAKE) manifest-add OS_VERSION=$(OS_VERSION) PLATFORM=$(PLATFORM);\
503+
$(MAKE) manifest-add CONTAINER_BUILDER=$(CONTAINER_BUILDER) OS=windows OS_VERSION=$(OS_VERSION) PLATFORM=$(PLATFORM);\
504504
),\
505505
$(MAKE) manifest-add PLATFORM=$(PLATFORM);\
506506
)\

0 commit comments

Comments
 (0)