fix lints

Signed-off-by: GitHub <[email protected]>

Author: rbtr

cns/NetworkContainerContract.go

@@ -201,7 +201,7 @@ func (f PodInfoByIPProviderFunc) PodInfoByIP() (map[string]PodInfo, error) {
 	return f()
 }
 
-var GlobalPodInfoScheme podInfoScheme = InterfaceIDPodInfoScheme
+var GlobalPodInfoScheme = InterfaceIDPodInfoScheme
 
 // podInfoScheme indicates which schema should be used when generating
 // the map key in the Key() function on a podInfo object.
@@ -319,7 +319,7 @@ func (p *podInfo) UnmarshalJSON(b []byte) error {
 		alias: (*alias)(p),
 	}
 	if err := json.Unmarshal(b, a); err != nil {
-		return err
+		return errors.Wrap(err, "failed to unmarshal podInfo")
 	}
 	p.Version = GlobalPodInfoScheme
 	return nil

cns/restserver/ipam_test.go

@@ -91,7 +91,7 @@ func newSecondaryIPConfig(ipAddress string, ncVersion int) cns.SecondaryIPConfig
 	}
 }
 
-func newPodState(ipaddress, id, ncid string, state types.IPState, ncVersion int) cns.IPConfigurationStatus {
+func newPodState(ipaddress, id, ncid string, state types.IPState, ncVersion int) cns.IPConfigurationStatus { //nolint:unparam // ignore unused parameter
 	ipconfig := newSecondaryIPConfig(ipaddress, ncVersion)
 	status := &cns.IPConfigurationStatus{
 		IPAddress: ipconfig.IPAddress,
@@ -131,7 +131,8 @@ func requestIPAddressAndGetState(t *testing.T, req cns.IPConfigsRequest) ([]cns.
 	return ipConfigStatus, nil
 }
 
-func newPodStateWithOrchestratorContext(ipaddress, id, ncid string, state types.IPState, prefixLength uint8, ncVersion int, podInfo cns.PodInfo) (cns.IPConfigurationStatus, error) {
+// nolint:unparam // ignore unused inputs
+func newPodStateWithOrchestratorContext(ipaddress, id, ncid string, state types.IPState, _ uint8, ncVersion int, podInfo cns.PodInfo) (cns.IPConfigurationStatus, error) {
 	ipconfig := newSecondaryIPConfig(ipaddress, ncVersion)
 	status := &cns.IPConfigurationStatus{
 		IPAddress: ipconfig.IPAddress,
@@ -144,6 +145,7 @@ func newPodStateWithOrchestratorContext(ipaddress, id, ncid string, state types.
 }
 
 // Test function to populate the IPConfigState
+// nolint: unparam // ignore unused return
 func updatePodIPConfigState(t *testing.T, svc *HTTPRestService, ipconfigs map[string]cns.IPConfigurationStatus, ncID string) error {
 	// Create the NC
 	secondaryIPConfigs := make(map[string]cns.SecondaryIPConfig)

cns/restserver/nodesubnet_test.go

@@ -6,8 +6,8 @@ import (
 	"testing"
 
 	"github.com/Azure/azure-container-networking/cns/logger"
-	"github.com/Azure/azure-container-networking/cns/stateprovider/cns"
 	"github.com/Azure/azure-container-networking/cns/restserver"
+	"github.com/Azure/azure-container-networking/cns/stateprovider/cns"
 	"github.com/Azure/azure-container-networking/cns/types"
 	"github.com/Azure/azure-container-networking/store"
 )

cns/stateprovider/cns/podinfoprovider_test.go

@@ -44,7 +44,6 @@ func TestNewCNSPodInfoProvider(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			got, err := podInfoProvider(tt.store)
 			if tt.wantErr {