updated logic to check for containment

Author: rejain789

cns/restserver/internalapi.go

@@ -746,8 +746,8 @@ func validateCIDRSuperset(newCIDR, oldCIDR string) bool {
 		return false
 	}
 
-	// Condition 2: Check if the base IP of oldCIDR is contained in newCIDR
-	if !newPrefix.Contains(oldPrefix.Addr()) {
+	// Condition 2: Check for Overlap - this will also ensure containment
+	if !newPrefix.Overlaps(oldPrefix) {
 		return false
 	}
 

cns/restserver/internalapi_test.go

@@ -133,6 +133,7 @@ func TestReconcileNCStatePrimaryIPChangeShouldNotFail(t *testing.T) {
 		{"10.0.1.0/24", "10.0.2.0/22"},
 		{"10.0.1.0/20", "10.0.1.0/18"},
 		{"10.0.1.0/19", "10.0.0.0/15"},
+		{"10.0.1.0/18", "10.0.1.0/18"},
 	}
 
 	// Run test cases