Skip to content

Commit e769fca

Browse files
committed
chore: pre-review cleanup
1 parent bede53a commit e769fca

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

.github/workflows/baseimages.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- uses: actions/setup-go@v5
2222
with:
2323
go-version-file: go.mod
24-
- name: go debug
24+
- name: go env
2525
run: |
2626
echo "GOPATH=$(go env GOPATH)" >> $GITHUB_ENV
2727
- name: Render Dockerfiles

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -916,13 +916,13 @@ test-extended-cyclonus: ## run the cyclonus test for npm.
916916
cd ..
917917

918918
test-azure-ipam: ## run the unit test for azure-ipam
919-
cd $(AZURE_IPAM_DIR) && go test -race -covermode atomic -coverprofile=../coverage-azure-ipam.out && go tool cover -func=../coverage-azure-ipam.out
919+
cd $(AZURE_IPAM_DIR) && go test -race -covermode atomic -coverprofile=../coverage-azure-ipam.out && go tool cover -func=../coverage-azure-ipam.out
920920

921921
test-azure-ip-masq-merger: ## run the unit test for azure-ip-masq-merger
922-
cd $(AZURE_IP_MASQ_MERGER_DIR) && go test -race -covermode atomic -coverprofile=../coverage-azure-ip-masq-merger.out && go tool cover -func=../coverage-azure-ip-masq-merger.out
922+
cd $(AZURE_IP_MASQ_MERGER_DIR) && go test -race -covermode atomic -coverprofile=../coverage-azure-ip-masq-merger.out && go tool cover -func=../coverage-azure-ip-masq-merger.out
923923

924924
test-azure-iptables-monitor: ## run the unit test for azure-iptables-monitor
925-
cd $(AZURE_IPTABLES_MONITOR_DIR) && go test -race -covermode atomic -coverprofile=../coverage-azure-iptables-monitor.out && go tool cover -func=../coverage-azure-iptables-monitor.out
925+
cd $(AZURE_IPTABLES_MONITOR_DIR) && go test -race -covermode atomic -coverprofile=../coverage-azure-iptables-monitor.out && go tool cover -func=../coverage-azure-iptables-monitor.out
926926

927927
kind:
928928
kind create cluster --config ./test/kind/kind.yaml
@@ -963,7 +963,7 @@ gitconfig: ## configure the local git repository
963963
@git config core.fsmonitor true
964964
@git config core.untrackedcache true
965965

966-
setup: install-hooks gitconfig ## performs common required repo setup
966+
setup: tools install-hooks gitconfig ## performs common required repo setup
967967

968968
##@ Tools
969969

scripts/install-protoc.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,15 @@ fi
3232
# install protoc-gen-go
3333
if [ ! -f ${GOPATH}/bin/protoc-gen-go ]; then
3434
echo "Installing protoc-gen-go"
35-
go install -modfile=${REPO_ROOT}/tools.go.mod github.com/golang/protobuf/protoc-gen-go@v1.26
35+
go install -modfile=${REPO_ROOT}/tools.go.mod github.com/golang/protobuf/protoc-gen-go
3636
else
3737
echo "protoc-gen-go already installed at ${GOPATH}/bin/protoc-gen-go"
3838
fi
3939

4040
# install protoc-gen-go-grpc
4141
if [ ! -f ${GOPATH}/bin/protoc-gen-go-grpc ]; then
4242
echo "Installing protoc-gen-go-grpc"
43-
go install -modfile=${REPO_ROOT}/tools.go.mod google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.1
43+
go install -modfile=${REPO_ROOT}/tools.go.mod google.golang.org/grpc/cmd/protoc-gen-go-grpc
4444
else
4545
echo "protoc-gen-go-grpc already installed at ${GOPATH}/bin/protoc-gen-go-grpc"
4646
fi

0 commit comments

Comments
 (0)