Skip to content

Commit e8afcd8

Browse files
author
Sheyla Trudo
committed
fixup! Separate Build Changes
1 parent b8badaa commit e8afcd8

File tree

2 files changed

+22
-8
lines changed

2 files changed

+22
-8
lines changed

.pipelines/trigger.yaml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,20 @@ resources:
3232
variables:
3333
# Local analysis is only enabled on PR branches
3434
Codeql.AnalyzeInPipeline: $[startsWith(variables['Build.SourceBranch'], 'refs/pull/')]
35+
Codeql.ADO.Build.Repository.Uri: $(Build.Repository.Uri)
36+
Codeql.ADO.Build.Repository.Name: $(Build.Repository.Name)
37+
Codeql.ADO.Build.SourceVersion: $(Build.SourceVersion)
38+
Codeql.ADO.Build.DefinitionName: $(Build.DefinitionName)
39+
Codeql.ADO.Build.BuildId: $(Build.BuildId)
40+
Codeql.ADO.System.CollectionUri: $(System.CollectionUri)
41+
Codeql.ADO.System.TeamProject: $(System.TeamProject)
42+
Codeql.ADO.System.JobId: $(System.JobId)
43+
Codeql.ADO.Build.Repository.LocalPath: $(Build.Repository.LocalPath)
44+
Codeql.ADO.Build.SourceBranch: $(Build.SourceBranch)
45+
Codeql.ADO.Build.Repository.Provider: $(Build.Repository.Provider)
46+
Codeql.ADO.Build.SourceBranchName: $(Build.SourceBranchName)
47+
Codeql.ADO.Build.SourcesDirectory: $(Build.SourcesDirectory)
48+
3549

3650
extends:
3751
template: v1/1ES.Unofficial.PipelineTemplate.yml@1ESPipelineTemplates

Makefile

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ azure-ipam-image: ## build azure-ipam container image.
399399
TARGET=$(OS) \
400400
OS=$(OS) \
401401
ARCH=$(ARCH) \
402-
$(DOCKER_BUILD_ARGS)
402+
EXTRA_BUILD_ARGS=$(DOCKER_BUILD_ARGS)
403403

404404
azure-ipam-image-push: ## push azure-ipam container image.
405405
$(MAKE) container-push \
@@ -438,7 +438,7 @@ ipv6-hp-bpf-image: ## build ipv6-hp-bpf container image.
438438
$(MAKE) container \
439439
DOCKERFILE=$(DOCKERFILE_PATH) \
440440
IMAGE=$(IPV6_HP_BPF_IMAGE) \
441-
EXTRA_BUILD_ARGS='$(DOCKER_BUILD_ARGS)'\
441+
EXTRA_BUILD_ARGS=$(DOCKER_BUILD_ARGS) \
442442
PLATFORM=$(PLATFORM) \
443443
TAG=$(IPV6_HP_BPF_IMAGE_PLATFORM_TAG) \
444444
TARGET=$(OS) \
@@ -475,7 +475,7 @@ cni-dockerfile-path:
475475
@echo "$(DOCKERFILE_PATH)"
476476

477477
cni-docker-build-args:
478-
$(eval DOCKER_BUILD_ARGS='--build-arg CNI_AI_PATH=$(CNI_AI_PATH) --build-arg CNI_AI_ID=$(CNI_AI_ID)')
478+
$(eval DOCKER_BUILD_ARGS="--build-arg CNI_AI_PATH=$(CNI_AI_PATH) --build-arg CNI_AI_ID=$(CNI_AI_ID)")
479479
@echo $(DOCKER_BUILD_ARGS)
480480

481481
cni-image: ## build cni container image.
@@ -487,7 +487,7 @@ cni-image: ## build cni container image.
487487
TARGET=$(OS) \
488488
OS=$(OS) \
489489
ARCH=$(ARCH) \
490-
EXTRA_BUILD_ARGS='$(DOCKER_BUILD_ARGS)'
490+
EXTRA_BUILD_ARGS=$(DOCKER_BUILD_ARGS)
491491

492492
cni-image-push: ## push cni container image.
493493
$(MAKE) container-push \
@@ -520,14 +520,14 @@ cns-dockerfile-path:
520520
@echo "$(DOCKERFILE_PATH)"
521521

522522
cns-docker-build-args:
523-
$(eval DOCKER_BUILD_ARGS='--build-arg CNS_AI_PATH=$(CNS_AI_PATH) --build-arg CNS_AI_ID=$(CNS_AI_ID)')
523+
$(eval DOCKER_BUILD_ARGS="--build-arg CNS_AI_PATH=$(CNS_AI_PATH) --build-arg CNS_AI_ID=$(CNS_AI_ID)")
524524
@echo $(DOCKER_BUILD_ARGS)
525525

526526
cns-image: ## build cns container image.
527527
$(MAKE) container \
528528
DOCKERFILE=$(DOCKERFILE_PATH) \
529529
IMAGE=$(CNS_IMAGE) \
530-
EXTRA_BUILD_ARGS='$(DOCKER_BUILD_ARGS)' \
530+
EXTRA_BUILD_ARGS=$(DOCKER_BUILD_ARGS) \
531531
PLATFORM=$(PLATFORM) \
532532
TAG=$(CNS_PLATFORM_TAG) \
533533
TARGET=$(OS) \
@@ -564,14 +564,14 @@ npm-dockerfile-path:
564564
@echo "$(DOCKERFILE_PATH)"
565565

566566
npm-docker-build-args:
567-
$(eval DOCKER_BUILD_ARGS='--build-arg NPM_AI_PATH=$(NPM_AI_PATH) --build-arg NPM_AI_ID=$(NPM_AI_ID)')
567+
$(eval DOCKER_BUILD_ARGS="--build-arg NPM_AI_PATH=$(NPM_AI_PATH) --build-arg NPM_AI_ID=$(NPM_AI_ID)")
568568
@echo $(DOCKER_BUILD_ARGS)
569569

570570
npm-image: ## build the npm container image.
571571
$(MAKE) container-$(CONTAINER_BUILDER) \
572572
DOCKERFILE=$(DOCKERFILE_PATH) \
573573
IMAGE=$(NPM_IMAGE) \
574-
EXTRA_BUILD_ARGS='$(DOCKER_BUILD_ARGS)' \
574+
EXTRA_BUILD_ARGS=$(DOCKER_BUILD_ARGS) \
575575
PLATFORM=$(PLATFORM) \
576576
TAG=$(NPM_PLATFORM_TAG) \
577577
TARGET=$(OS) \

0 commit comments

Comments
 (0)