resolved copilot comments

Author: rejain789

npm/pkg/controlplane/translation/translatePolicy.go

@@ -349,7 +349,7 @@ func peerAndPortRule(npmNetPol *policies.NPMNetworkPolicy, direction policies.Di
 			return err
 		}
 
-		err = checkForNamedPortType(portKind, npmLiteToggle)
+		err = checkForNamedPortType(npmNetPol, portKind, npmLiteToggle, direction, &ports[i], "")
 		if err != nil {
 			return err
 		}
@@ -381,7 +381,7 @@ func directPeerAndPortAllowRule(npmNetPol *policies.NPMNetworkPolicy, direction
 				return err
 			}
 
-			err = checkForNamedPortType(portKind, npmLiteToggle)
+			err = checkForNamedPortType(npmNetPol, portKind, npmLiteToggle, direction, &ports[i], cidr)
 			if err != nil {
 				return err
 			}
@@ -396,10 +396,6 @@ func directPeerAndPortAllowRule(npmNetPol *policies.NPMNetworkPolicy, direction
 			}
 
 			// Handle ports
-			if portKind == namedPortType {
-				return fmt.Errorf("named port not supported in policy %s (namespace: %s, direction: %s, cidr: %s, port: %v): %w",
-					npmNetPol.PolicyKey, npmNetPol.Namespace, direction, cidr, ports[i].Port, ErrUnsupportedNamedPort)
-			}
 			if portKind == numericPortType {
 				portInfo, protocol := numericPortRule(&ports[i])
 				acl.DstPorts = portInfo
@@ -694,9 +690,10 @@ func TranslatePolicy(npObj *networkingv1.NetworkPolicy, npmLiteToggle bool) (*po
 	return npmNetPol, nil
 }
 
-func checkForNamedPortType(portKind netpolPortType, npmLiteToggle bool) error {
+func checkForNamedPortType(npmNetPol *policies.NPMNetworkPolicy, portKind netpolPortType, npmLiteToggle bool, direction policies.Direction, port *networkingv1.NetworkPolicyPort, cidr string) error {
 	if npmLiteToggle && portKind == namedPortType {
-		return ErrUnsupportedNonCIDR
+		return fmt.Errorf("named port not supported in policy %s (namespace: %s, direction: %s, cidr: %s, port: %v, protocol: %v): %w",
+			npmNetPol.PolicyKey, npmNetPol.Namespace, direction, cidr, port.Port, port.Protocol, ErrUnsupportedNamedPort)
 	}
 	return nil
 }
@@ -717,7 +714,7 @@ func checkOnlyPortRuleExists(
 			if err != nil {
 				return err
 			}
-			err = checkForNamedPortType(portKind, npmLiteToggle)
+			err = checkForNamedPortType(npmNetPol, portKind, npmLiteToggle, direction, &ports[i], "")
 			if err != nil {
 				return err
 			}

npm/pkg/controlplane/translation/translatePolicy_test.go

@@ -3153,8 +3153,28 @@ func TestCheckForNamedPortType(t *testing.T) {
 	for _, tt := range tests {
 		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
-			// run the function passing in peers and a flag indicating whether npm lite is enabled
-			err := checkForNamedPortType(tt.portKind, tt.npmLiteEnabled)
+			// Create a mock NPM network policy for testing
+			npmNetPol := &policies.NPMNetworkPolicy{
+				PolicyKey: "test-policy/test",
+				Namespace: "test-namespace",
+			}
+
+			// Use the first port from test data, or create a default one if ports are empty
+			var testPort *networkingv1.NetworkPolicyPort
+			if len(tt.ports) > 0 {
+				testPort = &tt.ports[0]
+			} else {
+				// Create a default port for tests without specific port data
+				port := intstr.FromInt(8080)
+				protocol := v1.ProtocolTCP
+				testPort = &networkingv1.NetworkPolicyPort{
+					Protocol: &protocol,
+					Port:     &port,
+				}
+			}
+
+			// run the function passing in all required parameters
+			err := checkForNamedPortType(npmNetPol, tt.portKind, tt.npmLiteEnabled, policies.Ingress, testPort, "10.0.0.0/24")
 			if tt.wantErr {
 				require.Error(t, err)
 			} else {

npm/pkg/dataplane/policies/policy_windows.go

@@ -101,7 +101,7 @@ func (acl *ACLPolicy) convertToAclSettings(aclID string) (*NPMACLPolSettings, er
 	// Ignore adding ruletype for now as there is a bug
 	// policySettings.RuleType = hcn.RuleTypeSwitch
 
-	// HNS has confusing Local and Remote address defintions
+	// HNS has confusing Local and Remote address definitions
 	// For Traffic Direction INGRESS
 	// 	    LocalAddresses  = Source Sets
 	// 	    RemoteAddresses = Destination Sets