improve the logging

Author: behzad-mir

cns/cni-telemetry-sidecar/main.go

@@ -7,24 +7,38 @@ import (
 	"os/signal"
 	"syscall"
 
-	"github.com/Azure/azure-container-networking/cns/logger"
+	"github.com/Azure/azure-container-networking/cns/logger/v2"
+	cores "github.com/Azure/azure-container-networking/cns/logger/v2/cores"
+	"go.uber.org/zap"
 )
 
 var (
 	version    = "unknown"
 	configPath = flag.String("config", "/etc/cns/cns-config.json", "Path to CNS configuration file")
+	logLevel   = flag.String("log-level", "info", "Log level (debug, info, warn, error)")
 )
 
 func main() {
 	flag.Parse()
 
-	// Initialize logging for the CNI telemetry sidecar
-	logger.InitLogger("azure-cns-cni-telemetry-sidecar", 1, 1, "/var/log/azure-cns-telemetry")
-	defer logger.Close()
+	// Initialize main logger
+	zapLogger, cleanup, err := logger.New(&logger.Config{
+		Level: *logLevel,
+		File: &cores.FileConfig{
+			Filepath: "/var/log/azure-cni-telemetry-sidecar.log",
+		},
+	})
+	if err != nil {
+		panic("Failed to initialize logger: " + err.Error())
+	}
+	defer cleanup()
 
-	logger.Printf("Starting Azure CNI Telemetry Sidecar v%s", version)
+	zapLogger.Info("Starting Azure CNI Telemetry Sidecar",
+		zap.String("version", version),
+		zap.String("configPath", *configPath),
+		zap.String("logLevel", *logLevel))
 
-	// Create telemetry sidecar service
+	// Create telemetry sidecar service (using the one from sidecar.go)
 	sidecar := NewTelemetrySidecar(*configPath)
 
 	// Setup graceful shutdown context
@@ -37,15 +51,17 @@ func main() {
 
 	go func() {
 		sig := <-sigCh
-		logger.Printf("Received shutdown signal %v, initiating graceful shutdown", sig)
+		zapLogger.Info("Received shutdown signal, initiating graceful shutdown",
+			zap.String("signal", sig.String()))
 		cancel()
 	}()
 
-	// Run the telemetry sidecar
+	// Run the telemetry sidecar (using the Run method from sidecar.go)
 	if err := sidecar.Run(ctx); err != nil {
-		logger.Errorf("Azure CNI Telemetry Sidecar failed: %v", err)
+		zapLogger.Error("Azure CNI Telemetry Sidecar failed",
+			zap.Error(err))
 		os.Exit(1)
 	}
 
-	logger.Printf("Azure CNI Telemetry Sidecar stopped gracefully")
+	zapLogger.Info("Azure CNI Telemetry Sidecar stopped gracefully")
 }