address linter issues

Author: QxBytes

test/integration/prometheus/prometheus.go

@@ -86,7 +86,7 @@ func SelectMetric(metrics map[string]*io_prometheus_client.MetricFamily, name st
 // GetMetric is a convenience function to issue a web request to the specified url and then
 // select a particular metric that exactly matches the name and labels. The metric is then returned
 // and values can be retrieved based on what type of metric it is, for example .GetCounter().GetValue()
-func GetMetric(url string, name string, labels map[string]string) (*io_prometheus_client.Metric, error) {
+func GetMetric(url, name string, labels map[string]string) (*io_prometheus_client.Metric, error) {
 	metrics, err := GetMetrics(url)
 	if err != nil {
 		return nil, err

test/integration/prometheus/prometheus_test.go

@@ -119,7 +119,7 @@ func TestGetMetricValue(t *testing.T) {
 				require.Error(t, err)
 			} else {
 				require.NoError(t, err)
-				require.Equal(t, tt.expectedVal, val)
+				require.InDelta(t, tt.expectedVal, val, 0.01)
 			}
 		})
 	}

test/internal/kubernetes/utils.go

@@ -15,7 +15,6 @@ import (
 	"github.com/Azure/azure-container-networking/test/internal/retry"
 	ciliumv2 "github.com/cilium/cilium/pkg/k8s/apis/cilium.io/v2"
 	cilium "github.com/cilium/cilium/pkg/k8s/client/clientset/versioned"
-
 	"github.com/pkg/errors"
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
@@ -203,7 +202,7 @@ func MustSetUpRBAC(ctx context.Context, clientset *kubernetes.Clientset, rolePat
 	mustCreateRoleBinding(ctx, roleBindings, roleBinding)
 }
 
-func MustSetupConfigMap(ctx context.Context, clientset *kubernetes.Clientset, configMapPath string) (corev1.ConfigMap, func()) {
+func MustSetupConfigMap(ctx context.Context, clientset *kubernetes.Clientset, configMapPath string) (corev1.ConfigMap, func()) { // nolint
 	cm := mustParseConfigMap(configMapPath)
 	configmaps := clientset.CoreV1().ConfigMaps(cm.Namespace)
 	mustCreateConfigMap(ctx, configmaps, cm)
@@ -214,7 +213,7 @@ func MustSetupConfigMap(ctx context.Context, clientset *kubernetes.Clientset, co
 
 // MustSetupDaemonset is a convenience function to directly apply the daemonset at dsPath to the cluster,
 // returning the parsed daemonset struct and a cleanup function in the process
-func MustSetupDaemonset(ctx context.Context, clientset *kubernetes.Clientset, dsPath string) (appsv1.DaemonSet, func()) {
+func MustSetupDaemonset(ctx context.Context, clientset *kubernetes.Clientset, dsPath string) (appsv1.DaemonSet, func()) { // nolint
 	ds := MustParseDaemonSet(dsPath)
 	dsClient := clientset.AppsV1().DaemonSets(ds.Namespace)
 	MustCreateDaemonset(ctx, dsClient, ds)
@@ -223,7 +222,7 @@ func MustSetupDaemonset(ctx context.Context, clientset *kubernetes.Clientset, ds
 	}
 }
 
-func MustSetupDeployment(ctx context.Context, clientset *kubernetes.Clientset, depPath string) (appsv1.Deployment, func()) {
+func MustSetupDeployment(ctx context.Context, clientset *kubernetes.Clientset, depPath string) (appsv1.Deployment, func()) { // nolint
 	dep := MustParseDeployment(depPath)
 	depClient := clientset.AppsV1().Deployments(dep.Namespace)
 	MustCreateDeployment(ctx, depClient, dep)
@@ -232,7 +231,7 @@ func MustSetupDeployment(ctx context.Context, clientset *kubernetes.Clientset, d
 	}
 }
 
-func MustSetupServiceAccount(ctx context.Context, clientset *kubernetes.Clientset, serviceAccountPath string) (corev1.ServiceAccount, func()) {
+func MustSetupServiceAccount(ctx context.Context, clientset *kubernetes.Clientset, serviceAccountPath string) (corev1.ServiceAccount, func()) { // nolint
 	sa := mustParseServiceAccount(serviceAccountPath)
 	sas := clientset.CoreV1().ServiceAccounts(sa.Namespace)
 	mustCreateServiceAccount(ctx, sas, sa)
@@ -241,7 +240,7 @@ func MustSetupServiceAccount(ctx context.Context, clientset *kubernetes.Clientse
 	}
 }
 
-func MustSetupService(ctx context.Context, clientset *kubernetes.Clientset, servicePath string) (corev1.Service, func()) {
+func MustSetupService(ctx context.Context, clientset *kubernetes.Clientset, servicePath string) (corev1.Service, func()) { // nolint
 	svc := mustParseService(servicePath)
 	svcs := clientset.CoreV1().Services(svc.Namespace)
 	mustCreateService(ctx, svcs, svc)
@@ -250,7 +249,7 @@ func MustSetupService(ctx context.Context, clientset *kubernetes.Clientset, serv
 	}
 }
 
-func MustSetupLRP(ctx context.Context, clientset *cilium.Clientset, lrpPath string) (ciliumv2.CiliumLocalRedirectPolicy, func()) {
+func MustSetupLRP(ctx context.Context, clientset *cilium.Clientset, lrpPath string) (ciliumv2.CiliumLocalRedirectPolicy, func()) { // nolint
 	lrp := mustParseLRP(lrpPath)
 	lrps := clientset.CiliumV2().CiliumLocalRedirectPolicies(lrp.Namespace)
 	mustCreateCiliumLocalRedirectPolicy(ctx, lrps, lrp)

test/internal/kubernetes/utils_create.go

@@ -11,7 +11,6 @@ import (
 
 	ciliumv2 "github.com/cilium/cilium/pkg/k8s/apis/cilium.io/v2"
 	typedciliumv2 "github.com/cilium/cilium/pkg/k8s/client/clientset/versioned/typed/cilium.io/v2"
-
 	"github.com/pkg/errors"
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"