Skip to content

Conversation

@jpayne3506
Copy link
Contributor

Reason for Change:

Certain PR pipeline steps did not capture bash error codes correctly or overwrote them with successive calls.
In fixing this I also captured a missed input for the cilium-test.yaml template that also required fixes.

Issue Fixed:

Requirements:

Notes:
Instead of adding set -e everywhere we can also split out deleting namespaces, assigning variables, ect.
Exit codes get overwritten when any command is ran after a test i.e make test-validate-state | go test ...

@jpayne3506 jpayne3506 added ci Infra or tooling. release/latest Change affects latest release train needs-backport Change needs to be backported to previous release trains release/1.5 Change affects v1.5 release train labels Nov 8, 2024
@jpayne3506 jpayne3506 requested a review from a team as a code owner November 8, 2024 02:24
@jpayne3506 jpayne3506 requested a review from rajvinar November 8, 2024 02:24
@jpayne3506 jpayne3506 self-assigned this Nov 8, 2024
@jpayne3506 jpayne3506 force-pushed the jpayne3506/step-fail branch from 2069bf0 to 675f067 Compare November 8, 2024 17:59
paulyufan2
paulyufan2 previously approved these changes Nov 8, 2024
@jpayne3506 jpayne3506 enabled auto-merge November 12, 2024 18:07
@jpayne3506
Copy link
Contributor Author

/azp Run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jpayne3506 jpayne3506 added this pull request to the merge queue Nov 12, 2024
Merged via the queue into master with commit 1b5d3a1 Nov 12, 2024
14 checks passed
@jpayne3506 jpayne3506 deleted the jpayne3506/step-fail branch November 12, 2024 21:58
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* ci: Add exit code capture for PR pipeline

* ci: ignore errors from cilium status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling. needs-backport Change needs to be backported to previous release trains release/latest Change affects latest release train release/1.5 Change affects v1.5 release train

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants