Skip to content

Conversation

@jackieluc
Copy link
Member

@jackieluc jackieluc commented Nov 12, 2024

Reason for Change:
Inspired by @ramiro-gamarra's PR to emit config snapshots at an interval, we should do the same for CNS for a consistent view for both components.

Issue Fixed:

Requirements:

Notes:

@jackieluc jackieluc added cns Related to CNS. telemetry labels Nov 12, 2024
@jackieluc jackieluc requested a review from a team as a code owner November 12, 2024 22:44
@jackieluc jackieluc requested a review from neaggarwMS November 12, 2024 22:44
@jackieluc
Copy link
Member Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jackieluc jackieluc changed the title [CNS] add CNS config snapshot event metrics at an interval [CNS] add config snapshot event metrics at an interval Nov 12, 2024
@jackieluc
Copy link
Member Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jackieluc jackieluc enabled auto-merge November 19, 2024 23:51
@jackieluc jackieluc added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@jackieluc jackieluc added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@jackieluc jackieluc added this pull request to the merge queue Nov 20, 2024
Merged via the queue into Azure:master with commit bf2b3d2 Nov 21, 2024
14 checks passed
@jackieluc jackieluc deleted the jackieluc/config-snapshot-metric branch November 21, 2024 02:14
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* feat: add and expose new ConfigSnapshotIntervalInMins config

* feat: add interval event emitting of CNS config snapshot

* lint: address lint errors

* chore: send CNS config snapshot immediately

* test: refactor test to be less coupled

* lint

* fix: remove setting default ConfigSnapshotIntervalInMins

* chore: remove unnecessary comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cns Related to CNS. telemetry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants