-
Notifications
You must be signed in to change notification settings - Fork 260
[CNS] add config snapshot event metrics at an interval #3140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jackieluc
merged 9 commits into
Azure:master
from
jackieluc:jackieluc/config-snapshot-metric
Nov 21, 2024
Merged
[CNS] add config snapshot event metrics at an interval #3140
jackieluc
merged 9 commits into
Azure:master
from
jackieluc:jackieluc/config-snapshot-metric
Nov 21, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
reviewed
Nov 12, 2024
rbtr
reviewed
Nov 13, 2024
rbtr
reviewed
Nov 19, 2024
rbtr
approved these changes
Nov 19, 2024
Member
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* feat: add and expose new ConfigSnapshotIntervalInMins config * feat: add interval event emitting of CNS config snapshot * lint: address lint errors * chore: send CNS config snapshot immediately * test: refactor test to be less coupled * lint * fix: remove setting default ConfigSnapshotIntervalInMins * chore: remove unnecessary comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Inspired by @ramiro-gamarra's PR to emit config snapshots at an interval, we should do the same for CNS for a consistent view for both components.
Issue Fixed:
Requirements:
Notes: