Skip to content

Conversation

@huntergregory
Copy link
Contributor

@huntergregory huntergregory commented Jan 6, 2025

Reason for Change:
Missing telemetry in case of a few potential errors during NPM bootup.

Issue Fixed:
Fixes #3145

Requirements:

Notes:

metrics.SendErrorLog() doesn't work as intended in these three places since telemetry is not initialized until later:

if err != nil {
metrics.SendErrorLogAndMetric(util.NpmID, "Error: failed to retrieving kubernetes version with err: %s", err.Error())

nodeIP, err = util.NodeIP()
if err != nil {
metrics.SendErrorLogAndMetric(util.NpmID, "error: failed to get node IP while booting up: %v", err)

dp, err = dataplane.NewDataPlane(models.GetNodeName(), common.NewIOShim(), npmV2DataplaneCfg, stopChannel)
if err != nil {
metrics.SendErrorLogAndMetric(util.NpmID, "error: failed to create dataplane with error %v", err)

@huntergregory huntergregory force-pushed the huntergregory/telemetry branch from abc036d to e48cfc9 Compare January 6, 2025 20:43
@huntergregory
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huntergregory
Copy link
Contributor Author

/azp run NPM Conformance Tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huntergregory huntergregory added this pull request to the merge queue Jan 7, 2025
Merged via the queue into master with commit 7da20f5 Jan 7, 2025
27 checks passed
@huntergregory huntergregory deleted the huntergregory/telemetry branch January 7, 2025 07:34
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes something. npm Related to NPM.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

log: [NPM] log any error and make sure node ID is set before first log

3 participants