fix: [NPM] close telemetry handler before crashing #3333
Merged
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run Container Networking PR |
Contributor
Author
|
/azp run NPM Conformance Tests |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Hunter Gregory <[email protected]>
huntergregory
force-pushed
the
huntergregory/close-telemetry
branch
from
1249e1d to
f5b42ad
Compare
Contributor
Author
|
/azp run Azure Container Networking PR, NPM Conformance Tests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
vakalapa
approved these changes
Jan 8, 2025
4 tasks
rayaisaiah
pushed a commit
that referenced
this pull request
Jan 14, 2025
fix: close telemetry handler before crashing Signed-off-by: Hunter Gregory <[email protected]>
rayaisaiah
pushed a commit
that referenced
this pull request
Jan 14, 2025
fix: close telemetry handler before crashing Signed-off-by: Hunter Gregory <[email protected]>
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
* test: [NPM] fix windows unit test for policymanager (#3161) * test: fix windows unit test for policymanager Signed-off-by: Hunter Gregory <[email protected]> * fix(test): flip bool Signed-off-by: Hunter Gregory <[email protected]> --------- Signed-off-by: Hunter Gregory <[email protected]> * fix: [NPM] close telemetry handler before crashing (#3333) fix: close telemetry handler before crashing Signed-off-by: Hunter Gregory <[email protected]> * fix(log): time waiting for appinsights to close was unbounded (#3337) * fix: time waiting for appinsights to close was unbounded Signed-off-by: Hunter Gregory <[email protected]> * fix: close timer in case it hasn't fired yet Signed-off-by: Hunter Gregory <[email protected]> --------- Signed-off-by: Hunter Gregory <[email protected]> * resolved merge conflict as there isnt npm lite in v1.5 --------- Signed-off-by: Hunter Gregory <[email protected]> Co-authored-by: Hunter Gregory <[email protected]>
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
fix: close telemetry handler before crashing Signed-off-by: Hunter Gregory <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Fixes #3299
Requirements:
Notes: