Skip to content

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Jan 13, 2025

Reason for Change: Add timeout to HNS service restart so that CNS will fail out instead of hang during init if it gets stuck.

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr requested review from a team as code owners January 13, 2025 22:18
@rbtr rbtr requested review from ZetaoZhuang, Copilot, nddq and paulyufan2 and removed request for paulyufan2 January 13, 2025 22:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

@rbtr rbtr self-assigned this Jan 13, 2025
@rbtr rbtr added cns Related to CNS. fix Fixes something. labels Jan 13, 2025
@rbtr rbtr force-pushed the fix/hns-restart-timeout branch from db85fb6 to bc33abb Compare January 14, 2025 01:21
@rbtr rbtr enabled auto-merge January 14, 2025 16:28
@rbtr
Copy link
Collaborator Author

rbtr commented Jan 14, 2025

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@rbtr rbtr added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@rbtr rbtr added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@nddq nddq added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@rbtr rbtr added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@nddq nddq added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@rbtr rbtr added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@rbtr rbtr added this pull request to the merge queue Jan 17, 2025
Merged via the queue into master with commit 8eab96d Jan 18, 2025
14 checks passed
@rbtr rbtr deleted the fix/hns-restart-timeout branch January 18, 2025 00:37
rbtr added a commit that referenced this pull request Jan 23, 2025
rbtr added a commit that referenced this pull request Jan 23, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2025
* fix: prevent CNS hanging on HNS restart (#3343)

Signed-off-by: Evan Baker <[email protected]>

* disable gomnd

Signed-off-by: GitHub <[email protected]>

---------

Signed-off-by: Evan Baker <[email protected]>
Signed-off-by: GitHub <[email protected]>
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cns Related to CNS. fix Fixes something.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants