Skip to content

Conversation

@camrynl
Copy link
Contributor

@camrynl camrynl commented Feb 12, 2025

Reason for Change:
create dir for cilium 1.17 for use in pipelines/byocni testing

Issue Fixed:

Requirements:

Notes:

Copilot AI review requested due to automatic review settings February 12, 2025 17:29
@camrynl camrynl requested a review from a team as a code owner February 12, 2025 17:29
@camrynl camrynl requested a review from vipul-21 February 12, 2025 17:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 18 changed files in this pull request and generated no comments.

Files not reviewed (11)
  • test/integration/manifests/cilium/v1.16/cilium-agent/templates/daemonset.yaml: Evaluated as low risk
  • test/integration/manifests/cilium/v1.16/cilium-agent/templates/daemonset-dualstack.yaml: Evaluated as low risk
  • test/integration/manifests/cilium/v1.16/cilium-config/cilium-config-dualstack.yaml: Evaluated as low risk
  • test/integration/manifests/cilium/v1.16/cilium-config/cilium-config-hubble.yaml: Evaluated as low risk
  • test/integration/manifests/cilium/v1.16/cilium-config/cilium-config.yaml: Evaluated as low risk
  • test/integration/manifests/cilium/v1.17/cilium-agent/files/serviceaccount.yaml: Evaluated as low risk
  • test/integration/manifests/cilium/v1.17/cilium-operator/files/serviceaccount.yaml: Evaluated as low risk
  • test/integration/manifests/cilium/v1.17/cilium-operator/files/clusterrolebinding.yaml: Evaluated as low risk
  • test/integration/manifests/cilium/v1.17/cilium-agent/files/clusterrolebinding.yaml: Evaluated as low risk
  • test/integration/manifests/cilium/v1.17/cilium-config/cilium-config-dualstack.yaml: Evaluated as low risk
  • test/integration/manifests/cilium/v1.17/hubble/hubble-peer-svc.yaml: Evaluated as low risk
Comments suppressed due to low confidence (1)

test/integration/manifests/cilium/v1.17/cilium-config/cilium-config.yaml:1

  • The comment '#Not verified, placeholder' is unclear and potentially misleading. Please remove or clarify this comment.
apiVersion: v1 #Not verified, placeholder

jshr-w
jshr-w previously approved these changes Feb 12, 2025
Copy link
Contributor

@jshr-w jshr-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@camrynl camrynl added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 15, 2025
@jpayne3506 jpayne3506 added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2025
@camrynl camrynl added this pull request to the merge queue Feb 25, 2025
Merged via the queue into master with commit b8dc705 Feb 25, 2025
191 checks passed
@camrynl camrynl deleted the camrynl/cilium17 branch February 25, 2025 02:55
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* chore: add cilium 1.17 and chart updates for k8s 1.32

* fix: rename config path

* fix: make json path

* swap kpr to strict in hubble chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants