[Swiftv2 L1VH]Add multiple IB NICs UT #3476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Overview
This PR adds a new unit test to verify that multiple IB NICs are correctly added to the CNI result, supporting Azure Container Networking.
- Introduces TestMultipleIBNICsToResult to validate the handling of multiple backend NIC info.
- Sets up expected NIC info mapping and verifies it against the result from the CNSIPAMInvoker.
Reviewed Changes
| File | Description |
|---|---|
| cni/network/invoker_cns_test.go | Adds a unit test for validating multiple IB NIC additions to the CNI result |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Paul Yu <[email protected]>
QxBytes
approved these changes
Mar 5, 2025
shreyashastantram
approved these changes
Mar 6, 2025
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
approved these changes
Mar 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* add multiple IB NICs UT * Update cni/network/invoker_cns_test.go Co-authored-by: Copilot <[email protected]> Signed-off-by: Paul Yu <[email protected]> * fix linter issue * fix linter issue --------- Signed-off-by: Paul Yu <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR is to add multiple IB NICs Unit test
Issue Fixed:
Requirements:
Notes: