ci: Allow manual overwrite of k8s version in CI/CD #3575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- hack/aks/Makefile: Language not supported
Comments suppressed due to low confidence (3)
.pipelines/templates/create-cluster.yaml:35
- Consider quoting ${K8S_VERSION} to prevent potential word splitting issues. For example, use: if [ -n "${K8S_VERSION}" ]; then
if ! [ -z ${K8S_VERSION} ]; then
.pipelines/templates/create-cluster.jobs.yaml:46
- Consider quoting ${K8S_VERSION} to prevent word splitting issues. Using if [ -n "${K8S_VERSION}" ]; then would be more robust.
if ! [ -z ${K8S_VERSION} ]; then
.pipelines/cni/load-test-templates/create-cluster-template.yaml:21
- Consider quoting ${K8S_VERSION} to avoid potential errors due to word splitting. A recommended improvement is: if [ -n "${K8S_VERSION}" ]; then
if ! [ -z ${K8S_VERSION} ]; then
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
camrynl
approved these changes
Apr 7, 2025
vipul-21
approved these changes
Apr 7, 2025
auto-merge was automatically disabled
April 7, 2025 23:27
Pull Request is not mergeable
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* ci: add K8S_VER to output for make vars * ci: Allow manual overwrite of k8s version in CI/CD * chore: rephrase terminal output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Enables testing of various Kubernetes versions against master.
Issue Fixed:
Requirements:
Notes:
Does not impact functionality of PR or Releases.
Using variable
${K8S_VERSION}ACN PR - https://msazure.visualstudio.com/One/_build/results?buildId=120416666&view=logs&j=b7272be1-c4e1-5606-108c-57e47d6749ec&t=24d1cf9e-6a2a-5c4b-89db-514da0326b17&l=77
CNI Release Test - https://msazure.visualstudio.com/One/_build/results?buildId=120417599&view=logs&j=5880768e-a1e2-5440-d89b-0c014d2bdd3f&t=36f18d29-ef7e-52ae-b9f6-f2d795e40dd6&l=74