ci: Add Binary Signing Task #3649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/acn run ACN Test Unofficial |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a CI task to sign build binaries across multiple platforms.
- Adds a new pipeline job block in run-pipeline.yaml for binary signing with OS-specific details.
- Extends binaries.jobs.yaml with a conditional branch to execute signing when the "official" parameter is true.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .pipelines/run-pipeline.yaml | Adds new signing jobs for Linux/AMD64, Windows/AMD64, and Linux/ARM64 using a shared template. |
| .pipelines/build/binaries.jobs.yaml | Introduces a conditional branch that executes signing tasks when the official flag is set. |
Contributor
Author
|
/azp run ACN Test Unofficial |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506
requested changes
May 28, 2025
Contributor
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rohitams
approved these changes
May 28, 2025
jpayne3506
approved these changes
May 29, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* Add Explicit Binary Signing Task * fixup! Add Explicit Binary Signing Task * fixup! Add Explicit Binary Signing Task * fixup! Add Explicit Binary Signing Task * fixup! Add Explicit Binary Signing Task * fixup! Add Explicit Binary Signing Task * fixup! Add Explicit Binary Signing Task * fixup! Add Explicit Binary Signing Task * fixup! Add Explicit Binary Signing Task * fixup! Add Explicit Binary Signing Task * fixup! Add Explicit Binary Signing Task * Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * fixup! fixup! Use Signed Binaries for Docker Build * chore: comment out NPM jobs/steps --------- Co-authored-by: jpayne3506 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR enables us to build signed binaries.
Scripts part out the builder portions of the dockerfiles to allow us to sign the binaries that are internal to the images.
The packages are then added to the image during build time. This results in signed binaries as an integrated part of our built images.
Also updated the build time image name to switch the docker image path.
Issue Fixed:
Requirements:
Notes: