Skip to content

Conversation

@camrynl
Copy link
Contributor

@camrynl camrynl commented May 19, 2025

Reason for Change:
Remove restart cns and validate pods check since we have coverage for this is make test-load
Remove deletion echo-external-node deployment since issue is closed cilium/cilium-cli#67

Issue Fixed:

Requirements:

Notes:

Copilot AI review requested due to automatic review settings May 19, 2025 21:18
@camrynl camrynl added the ci Infra or tooling. label May 19, 2025
@camrynl camrynl requested a review from a team as a code owner May 19, 2025 21:18
@camrynl camrynl requested a review from tamilmani1989 May 19, 2025 21:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an outdated step that restarted CNS and validated pods, as its functionality is now covered by the “make test-load” command.

  • Removed a script step that performed pod validation and CNS restart.
  • Cleaned up the YAML pipeline by eliminating redundant steps.

@camrynl camrynl changed the title chore: address todo remove repeated validate pods check chore: address todo items in cilium e2e templates May 19, 2025
Copy link
Contributor

@jpayne3506 jpayne3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ltgm 🚀

@camrynl camrynl added this pull request to the merge queue May 20, 2025
Merged via the queue into master with commit 67d2c5a May 21, 2025
96 of 97 checks passed
@camrynl camrynl deleted the camrynl/remove-validate-pods branch May 21, 2025 00:42
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* chore: address todo remove repeated validate pods check

* chore: address todo delete echo-external-node deployment and deleting connectivity test resources

* delete deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cilium connectivity test leaves state behind in the cluster on unclean exit

4 participants