feat: add cilium nodesubnet target to hack/Makefile #3677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new Makefile target for provisioning an AKS cluster with Cilium on a dedicated Nodesubnet.
- Introduces
nodesubnet-cilium-uptarget with Azure CLI flags for Cilium dataplane - Uses existing RG, IPv4, and overlay prerequisites and sets kubeconfig
- Mirrors pattern of other cluster-creation targets in
hack/aks/Makefile
Comments suppressed due to low confidence (2)
hack/aks/Makefile:396
- Introduce a test or integration check to ensure the new
nodesubnet-cilium-upMake target behaves as expected with its flags and prerequisites.
nodesubnet-cilium-up: rg-up ipv4 overlay-net-up ## Brings up a Nodesubnet Cilium cluster
hack/aks/Makefile:396
- Add this new target to the project's documentation or README so users know about the
nodesubnet-cilium-upoption and its flags.
nodesubnet-cilium-up: rg-up ipv4 overlay-net-up ## Brings up a Nodesubnet Cilium cluster
Co-authored-by: Copilot <[email protected]> Signed-off-by: Santhosh Prabhu <[email protected]>
…com:Azure/azure-container-networking into sanprabhu/cilium-nodesubnet-target-makefile
rbtr
previously approved these changes
May 21, 2025
Collaborator
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506
previously approved these changes
May 21, 2025
Contributor
jpayne3506
left a comment
jpayne3506
left a comment
There was a problem hiding this comment.
Lgtm 🚀
Add it to the README as well?
?
Contributor
Author
|
@rbtr @jpayne3506 Addressed John's comment, kindly take another look. |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506
approved these changes
May 21, 2025
krunaljain
approved these changes
May 21, 2025
rbtr
approved these changes
May 22, 2025
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* feat: nodesubnet cilium target in makefile * chore: cleanup * Update hack/aks/Makefile Co-authored-by: Copilot <[email protected]> Signed-off-by: Santhosh Prabhu <[email protected]> * chore: make dockerfiles * fix: add description to readme --------- Signed-off-by: Santhosh Prabhu <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Cilium Nodesubnet support is now GA across all regions. This PR adds a target to our makefile to create Cilium Nodesubnet clusters.
Issue Fixed:
Requirements:
Notes: