fix: use "vEthernet (LoopbackAdapterHostNCConnectivity)" when CNS is … #3693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the loopback adapter name used in CNS to explicitly reference the vEthernet adapter when checking for the existence of the required network interface.
- Updated the loopback adapter name constant to "vEthernet (LoopbackAdapterHostNCConnectivity)".
- Modified the interface existence check to use the updated constant.
Comments suppressed due to low confidence (1)
cns/hnsclient/hnsclient_windows.go:57
- [nitpick] Consider renaming 'vEthernethostNCLoopbackAdapterName' to 'vEthernetHostNCLoopbackAdapterName' for improved readability and consistent camel casing relative to the previously defined 'hostNCLoopbackAdapterName'.
vEthernethostNCLoopbackAdapterName = "vEthernet (LoopbackAdapterHostNCConnectivity)"
behzad-mir
force-pushed
the
v1.6.11-hotfix.20250529
branch
from
bf4b418 to
16e2cde
Compare
rbtr
reviewed
May 29, 2025
behzad-mir
force-pushed
the
v1.6.11-hotfix.20250529
branch
from
16e2cde to
c1c1c4e
Compare
msvik
reviewed
May 30, 2025
msvik
previously approved these changes
May 30, 2025
behzad-mir
force-pushed
the
v1.6.11-hotfix.20250529
branch
from
c1c1c4e to
d3c9b1f
Compare
behzad-mir
force-pushed
the
v1.6.11-hotfix.20250529
branch
2 times, most recently
from
a1cd2d8 to
6dc6e58
Compare
msvik
reviewed
May 30, 2025
…checking for existance of loopback adapter for Apipa network Creation.
behzad-mir
force-pushed
the
v1.6.11-hotfix.20250529
branch
from
6dc6e58 to
eb0cd87
Compare
msvik
approved these changes
May 30, 2025
jpayne3506
approved these changes
May 30, 2025
Contributor
santhoshmprabhu
left a comment
santhoshmprabhu
left a comment
There was a problem hiding this comment.
Can we please add a UT?
santhoshmprabhu
approved these changes
May 30, 2025
Contributor
santhoshmprabhu
left a comment
santhoshmprabhu
left a comment
There was a problem hiding this comment.
Approving to expedite fix for Sev2, tests to be added in follow up.
Contributor
Author
Will do a UT on a follow up PR |
santhoshmprabhu
approved these changes
May 30, 2025
Collaborator
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the wrong network interface name was used when checking for existing loopback adapters in the CNS code. Key changes include introducing a new constant for the vEthernet loopback adapter name and updating the interface existence check to cover both adapter naming schemes.
Comments suppressed due to low confidence (1)
cns/hnsclient/hnsclient_windows.go:57
- [nitpick] The constant name 'vEthernethostNCLoopbackAdapterName' could be improved for clarity and consistency; consider renaming it to 'vEthernetHostNCLoopbackAdapterName'.
vEthernethostNCLoopbackAdapterName = "vEthernet (" + hostNCLoopbackAdapterName + ")"
rbtr
approved these changes
May 30, 2025
Copilot AI
added a commit
that referenced
this pull request
May 30, 2025
…3693 Co-authored-by: behzad-mir <[email protected]>
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
#3693) fix: use "vEthernet (LoopbackAdapterHostNCConnectivity)" when CNS is checking for existance of loopback adapter for Apipa network Creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CNS code currently will call to the net.InterfaceByName(LoopbackAdapterHostNCConnectivity) to check for the existing Loopback interface when the Loopback adapter has not been created for Apipa HNSNetwork. This change will make CNS to also check for existence of the interface: "vEthernet (LoopbackAdapterHostNCConnectivity)" in case that HNSNetwork Has not been rehydrated, and the loopback interface is leaked.
Reason for Change:
Issue Fixed:
Requirements:
Notes: