ci: Remove File Copy and Add Image Build Stage to Regular Build #3769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR streamlines the CI by removing an unnecessary file copy step when no coverage output exists and ensures image manifests are built on non-pull requests.
- Remove copying of
coverage-all.outin unit test stage - Always run the main build stage (no pull-request gating)
- Wrap the manifests (image build) stage in a non-pull-request conditional
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .pipelines/templates/run-unit-tests.stages.yaml | Removed the cp coverage-all.out step to prevent errors |
| .pipelines/run-pipeline.yaml | Dropped PR-only condition on build stage; added non-PR conditional around manifests stage |
Comments suppressed due to low confidence (1)
.pipelines/run-pipeline.yaml:182
- Ensure this
- ${{ if ... }}block is indented exactly the same as the other top-level stages entries; a misaligned dash can break the YAML list structure and cause parsing errors.
- ${{ if not(contains(variables['Build.SourceBranch'], 'refs/pull')) }}:
isaac-dasan
approved these changes
Jul 2, 2025
QxBytes
approved these changes
Jul 3, 2025
Contributor
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506
approved these changes
Jul 3, 2025
jpayne3506
added
ci
4 tasks
jpayne3506
pushed a commit
that referenced
this pull request
Jul 28, 2025
* Remove File Copy * Add Image Builds to Regular Pipeline Execution
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
* Fixing build pipeline for 1.6 release * ci: Remove File Copy and Add Image Build Stage to Regular Build (#3769) * Remove File Copy * Add Image Builds to Regular Pipeline Execution * ci: enable NPM build --------- Co-authored-by: Amilcar Aponte Jimenez <[email protected]> Co-authored-by: sheylatrudo <[email protected]>
jpayne3506
removed
the
needs-backport
NihaNallappagari
pushed a commit
to NihaNallappagari/azure-container-networking
that referenced
this pull request
Sep 4, 2025
…e#3769) * Remove File Copy * Add Image Builds to Regular Pipeline Execution
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* Remove File Copy * Add Image Builds to Regular Pipeline Execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
There is an error on the file copy because the cover-all.out is not generated by the Official or Unofficial builds. Removing the copy should fix this.
The images aren't currently built during general pipeline execution. This will allow us to make sure that we are able to build images when changes are submitted.
Notes: