fix: combine repeated az aks create fields #3780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpayne3506
added
needs-backport
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates repeated Azure CLI parameters in the Makefile by introducing a COMMON_AKS_FIELDS variable to reduce duplication and ensure consistency across all az aks create commands. The change addresses inconsistencies that led to missed OS_SKU end-to-end tests.
- Extracts common
az aks createparameters into a reusableCOMMON_AKS_FIELDSvariable - Replaces duplicated parameter lists across all cluster creation targets with the common variable
- Adds the new variable to the
varstarget for visibility
Comments suppressed due to low confidence (2)
tamilmani1989
approved these changes
Jul 9, 2025
QxBytes
approved these changes
Jul 9, 2025
rbtr
approved these changes
Jul 9, 2025
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
NihaNallappagari
pushed a commit
to NihaNallappagari/azure-container-networking
that referenced
this pull request
Sep 4, 2025
* ci: combine repeated az aks create fields * ci: move az aks create into common field * chore: cleanup spacing * revert: dont touch swiftv2
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* ci: combine repeated az aks create fields * ci: move az aks create into common field * chore: cleanup spacing * revert: dont touch swiftv2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Inconsistencies across make recipes led to missed OS_SKU usage within e2e.
Issue Fixed:
Requirements:
Notes: