-
Notifications
You must be signed in to change notification settings - Fork 260
Add status to mtpnc crd #4070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add status to mtpnc crd #4070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds status tracking functionality to the MultitenantPodNetworkConfig (MTPNC) Custom Resource Definition. The changes introduce a comprehensive status enumeration and corresponding fields to track the overall state and transitions of MTPNC resources.
- Adds
MTPNCStatustype with 9 different status values covering various operational states - Extends
MultitenantPodNetworkConfigStatusstruct with status and timestamp fields - Includes kubebuilder validation annotations for proper CRD generation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Azure Pipelines successfully started running 1 pipeline(s). |
isaac-dasan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please explain the requirement for these individual statuses? Like for example pending - what is the use case for this? subnetExhaustion doesn't make sense in MTPNC. It should have been caught in PNI and it's probably more appropriate to say something like- IP exhausted for PNI.
@isaac-dasan I will update the 1 pager and link it here for requirements. subnetExhaustion is for dynamic allocation not static/explicit allocation / pni related error |
miguelgoms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending update of enums to separate user-actionable errors.
@miguelgoms Added |
ac2ff70
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* add status to mtpnc crd * update mtpnc status * update mtpnc status only * fix lint formating errs * add crd manifest * update mtpnc statuses * fix status enum * address pr feedback * fix lint * add missing file
Reason for Change:
Add Status to MTPNC crd
Issue Fixed:
Requirements:
Notes: