Skip to content

Conversation

@aggarwal0009
Copy link
Contributor

Reason for Change:
Add Status to MTPNC crd

Issue Fixed:

Requirements:

Notes:

@aggarwal0009 aggarwal0009 requested a review from a team as a code owner October 8, 2025 21:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds status tracking functionality to the MultitenantPodNetworkConfig (MTPNC) Custom Resource Definition. The changes introduce a comprehensive status enumeration and corresponding fields to track the overall state and transitions of MTPNC resources.

  • Adds MTPNCStatus type with 9 different status values covering various operational states
  • Extends MultitenantPodNetworkConfigStatus struct with status and timestamp fields
  • Includes kubebuilder validation annotations for proper CRD generation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@isaac-dasan isaac-dasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain the requirement for these individual statuses? Like for example pending - what is the use case for this? subnetExhaustion doesn't make sense in MTPNC. It should have been caught in PNI and it's probably more appropriate to say something like- IP exhausted for PNI.

@aggarwal0009
Copy link
Contributor Author

Can you please explain the requirement for these individual statuses? Like for example pending - what is the use case for this? subnetExhaustion doesn't make sense in MTPNC. It should have been caught in PNI and it's probably more appropriate to say something like- IP exhausted for PNI.

@isaac-dasan I will update the 1 pager and link it here for requirements.

subnetExhaustion is for dynamic allocation not static/explicit allocation / pni related error

Copy link
Contributor

@miguelgoms miguelgoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending update of enums to separate user-actionable errors.

@aggarwal0009
Copy link
Contributor Author

pending update of enums to separate user-actionable errors.

@miguelgoms Added

miguelgoms
miguelgoms previously approved these changes Oct 13, 2025
isaac-dasan
isaac-dasan previously approved these changes Oct 13, 2025
@aggarwal0009 aggarwal0009 dismissed stale reviews from isaac-dasan and miguelgoms via ac2ff70 October 13, 2025 23:08
@aggarwal0009
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

miguelgoms
miguelgoms previously approved these changes Oct 14, 2025
isaac-dasan
isaac-dasan previously approved these changes Oct 14, 2025
@aggarwal0009
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aggarwal0009 aggarwal0009 added this pull request to the merge queue Oct 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2025
@aggarwal0009 aggarwal0009 added this pull request to the merge queue Oct 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 15, 2025
@aggarwal0009 aggarwal0009 added this pull request to the merge queue Oct 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2025
@aggarwal0009 aggarwal0009 added this pull request to the merge queue Oct 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2025
@miguelgoms miguelgoms added this pull request to the merge queue Oct 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2025
@aggarwal0009 aggarwal0009 added this pull request to the merge queue Oct 15, 2025
Merged via the queue into master with commit a3f179b Oct 15, 2025
12 of 13 checks passed
@aggarwal0009 aggarwal0009 deleted the ankaggar/mtpnc-status branch October 15, 2025 21:50
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* add status to mtpnc crd

* update mtpnc status

* update mtpnc status only

* fix lint formating errs

* add crd manifest

* update mtpnc statuses

* fix status enum

* address pr feedback

* fix lint

* add missing file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants