Expanding mtpnc status to include delete status #4085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Expands MultitenantPodNetworkConfig visibility and lifecycle status tracking.
- Adds PodUID and Status printer columns; removes PodNetwork printer column.
- Introduces new MTPNCStatusDeleting status constant.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crd/multitenancy/manifests/multitenancy.acn.azure.com_multitenantpodnetworkconfigs.yaml | Adjusts CRD printer columns to include PodUID and Status, removes PodNetwork. |
| crd/multitenancy/api/v1alpha1/multitenantpodnetworkconfig.go | Adds PodUID and Status printcolumn annotations and new Deleting status constant. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
crd/multitenancy/manifests/multitenancy.acn.azure.com_multitenantpodnetworkconfigs.yaml
Show resolved
Hide resolved
isaac-dasan
reviewed
Oct 21, 2025
isaac-dasan
previously approved these changes
Oct 21, 2025
aggarwal0009
previously approved these changes
Oct 21, 2025
ashvindeodhar
previously approved these changes
Oct 21, 2025
Contributor
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
miguelgoms
requested changes
Oct 22, 2025
shreyashastantram
dismissed stale reviews from ashvindeodhar, aggarwal0009, and isaac-dasan
via
7ddb56b
isaac-dasan
previously approved these changes
Oct 22, 2025
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
miguelgoms
approved these changes
Oct 23, 2025
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
sivakami-projects
pushed a commit
to sivakami-projects/azure-container-networking
that referenced
this pull request
Oct 29, 2025
* Adding delete timestamp check * Adding status and removing deprecated fields from output * Revert MTPNC deletion timestamp check * fix: removing unused fields * fix: removing unused fields * Adding documentation for the status * Formatting the config file * Addressing PR comments * Changing type for pod uid
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 29, 2025
* Adding delete timestamp check * Adding status and removing deprecated fields from output * Revert MTPNC deletion timestamp check * fix: removing unused fields * fix: removing unused fields * Adding documentation for the status * Formatting the config file * Addressing PR comments * Changing type for pod uid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: