Skip to content

Expanding mtpnc status to include delete status #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 24, 2025
Merged

Expanding mtpnc status to include delete status #4085

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2133bc0
Adding delete timestamp check
shreyashastantram Oct 14, 2025
371b8ab
Adding status and removing deprecated fields from output
shreyashastantram Oct 16, 2025
423a320
Revert MTPNC deletion timestamp check
shreyashastantram Oct 17, 2025
9745204
fix: removing unused fields
shreyashastantram Oct 21, 2025
2059816
fix: removing unused fields
shreyashastantram Oct 21, 2025
b60a9d1
Adding documentation for the status
shreyashastantram Oct 21, 2025
c125815
Formatting the config file
shreyashastantram Oct 21, 2025
7ddb56b
Addressing PR comments
shreyashastantram Oct 22, 2025
43fb4d0
Changing type for pod uid
shreyashastantram Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions crd/multitenancy/api/v1alpha1/multitenantpodnetworkconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ import (
// +kubebuilder:metadata:labels=managed=
// +kubebuilder:metadata:labels=owner=
// +kubebuilder:printcolumn:name="PodNetworkInstance",type=string,JSONPath=`.spec.podNetworkInstance`
// +kubebuilder:printcolumn:name="PodNetwork",type=string,JSONPath=`.spec.podNetwork`
// +kubebuilder:printcolumn:name="PodName",type=string,JSONPath=`.spec.podName`
// +kubebuilder:printcolumn:name="PodUID",type=string,JSONPath=`.spec.podUID`
// +kubebuilder:printcolumn:name="Status",type=string,JSONPath=`.status.status`
type MultitenantPodNetworkConfig struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
Expand Down Expand Up @@ -64,17 +65,26 @@ const (
)

// MTPNCStatus indicates the high-level status of MultitenantPodNetworkConfig
// +kubebuilder:validation:Enum=Ready;Pending;InternalError;PNINotFound;PNINotReady;NodeCapacityExceeded;IPsExhausted
// +kubebuilder:validation:Enum=Ready;Pending;InternalError;PNINotFound;PNINotReady;NodeCapacityExceeded;IPsExhausted;Deleting
type MTPNCStatus string

const (
MTPNCStatusReady MTPNCStatus = "Ready"
MTPNCStatusPending MTPNCStatus = "Pending"
MTPNCStatusInternalError MTPNCStatus = "InternalError"
MTPNCStatusPNINotFound MTPNCStatus = "PNINotFound"
MTPNCStatusPNINotReady MTPNCStatus = "PNINotReady"
// MTPNCStatusReady indicates the MTPNC has been successfully programmed and is ready for use
MTPNCStatusReady MTPNCStatus = "Ready"
// MTPNCStatusPending indicates the MTPNC is awaiting processing
MTPNCStatusPending MTPNCStatus = "Pending"
// MTPNCStatusInternalError indicates an internal error occurred while processing the MTPNC
MTPNCStatusInternalError MTPNCStatus = "InternalError"
// MTPNCStatusPNINotFound indicates the referenced PodNetworkInstance was not found
MTPNCStatusPNINotFound MTPNCStatus = "PNINotFound"
// MTPNCStatusPNINotReady indicates the referenced PodNetworkInstance is not yet ready
MTPNCStatusPNINotReady MTPNCStatus = "PNINotReady"
// MTPNCStatusNodeCapacityExceeded indicates the node has exceeded its capacity for network resources
MTPNCStatusNodeCapacityExceeded MTPNCStatus = "NodeCapacityExceeded"
MTPNCStatusIPsExhausted MTPNCStatus = "IPsExhausted"
// MTPNCStatusIPsExhausted indicates no IP addresses are available for allocation
MTPNCStatusIPsExhausted MTPNCStatus = "IPsExhausted"
// MTPNCStatusDeleting indicates MTPNC is being deleted, status may not be set at the same time as deletionTimestamp.
MTPNCStatusDeleting MTPNCStatus = "Deleting"
)

type InterfaceInfo struct {
Expand Down
2 changes: 1 addition & 1 deletion crd/multitenancy/api/v1alpha1/podnetwork.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
// +kubebuilder:printcolumn:name="Network",type=string,priority=1,JSONPath=`.spec.networkID`
// +kubebuilder:printcolumn:name="Subnet",type=string,priority=1,JSONPath=`.spec.subnetResourceID`
// +kubebuilder:printcolumn:name="SubnetGUID",type=string,priority=1,JSONPath=`.spec.subnetGUID`
// +kubebuilder:printcolumn:name="DeviceType",type=string,priority=1,JSONPath=`.spec.subnetGUID`
// +kubebuilder:printcolumn:name="DeviceType",type=string,priority=1,JSONPath=`.spec.deviceType`
type PodNetwork struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
Expand Down
1 change: 0 additions & 1 deletion crd/multitenancy/api/v1alpha1/podnetworkinstance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import (
// +kubebuilder:metadata:labels=managed=
// +kubebuilder:metadata:labels=owner=
// +kubebuilder:printcolumn:name="Status",type=string,JSONPath=`.status.status`
// +kubebuilder:printcolumn:name="PodNetworks",priority=1,type=string,JSONPath=`.spec.podNetworks`
type PodNetworkInstance struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
Expand Down
10 changes: 7 additions & 3 deletions crd/multitenancy/manifests/multitenancy.acn.azure.com_multitenantpodnetworkconfigs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,15 @@ spec:
- jsonPath: .spec.podNetworkInstance
name: PodNetworkInstance
type: string
- jsonPath: .spec.podNetwork
name: PodNetwork
type: string
- jsonPath: .spec.podName
name: PodName
type: string
- jsonPath: .spec.podUID
name: PodUID
type: string
- jsonPath: .status.status
name: Status
type: string
name: v1alpha1
schema:
openAPIV3Schema:
Expand Down Expand Up @@ -154,6 +157,7 @@ spec:
- PNINotReady
- NodeCapacityExceeded
- IPsExhausted
- Deleting
type: string
type: object
type: object
Expand Down
4 changes: 0 additions & 4 deletions crd/multitenancy/manifests/multitenancy.acn.azure.com_podnetworkinstances.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ spec:
- jsonPath: .status.status
name: Status
type: string
- jsonPath: .spec.podNetworks
name: PodNetworks
priority: 1
type: string
name: v1alpha1
schema:
openAPIV3Schema:
Expand Down
2 changes: 1 addition & 1 deletion crd/multitenancy/manifests/multitenancy.acn.azure.com_podnetworks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
name: SubnetGUID
priority: 1
type: string
- jsonPath: .spec.subnetGUID
- jsonPath: .spec.deviceType
name: DeviceType
priority: 1
type: string
Expand Down
Loading