ci: clean up disk space before build and skip windows port forward #4109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the pipeline to separate NPM container builds into a dedicated stage and adds disk space management to prevent build failures due to insufficient space.
- NPM container builds moved from the
containerizestage to a newcontainerize_npmstage - Added disk space cleanup script that removes unnecessary hosted tooling before builds
- Reduced image build retry count from 3 to 2
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .pipelines/pipeline.yaml | Extracted NPM build jobs into a new containerize_npm stage and updated the publish_npm stage dependency accordingly |
| .pipelines/containers/container-template.yaml | Added disk space cleanup and monitoring steps, reduced retry count to 2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
QxBytes
changed the title
jpayne3506
approved these changes
Nov 5, 2025
Contributor
jpayne3506
left a comment
jpayne3506
left a comment
There was a problem hiding this comment.
lgtm.
When we backport make sure to add disk cleanup to signed flow as well.
https://github.com/Azure/azure-container-networking/blob/b2762a36e7243523ff4758b4a3244f373f5d9442/.… -> azure-container-networking/.pipelines/build/images.jobs.yaml at release/v1.6 · Azure/azure-containe…
rayaisaiah
approved these changes
Nov 5, 2025
sivakami-projects
pushed a commit
that referenced
this pull request
Nov 9, 2025
…4109) * clean up disk space before build * skip portforward e2e in windows
4 tasks
QxBytes
added a commit
that referenced
this pull request
Nov 12, 2025
…4109) * clean up disk space before build * skip portforward e2e in windows
4 tasks
QxBytes
added a commit
that referenced
this pull request
Nov 12, 2025
…4109) * clean up disk space before build * skip portforward e2e in windows
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Previously, building npm images would cause the agent to run out of disk space. This PR adds a step before building the image which cleans up unneeded files (from: https://github.com/cilium/cilium/blob/v1.16.8/.github/actions/disk-cleanup/action.yaml).
Also splits npm into its own stage and displays disk usage before and after disk cleanup and image build.
Also skips windows port forward tests
Issue Fixed:
Requirements:
Notes:
Run: https://msazure.visualstudio.com/One/_build/results?buildId=142753721&view=results