Address Brandon's PR feedback: reduce logging, use context.ui, add l10n

- Remove root-level package-lock.json (unnecessary)
- Reduce excessive logging in RevealStep.ts
  - Remove verbose appendLog calls throughout
  - Use .debug() and .error() for appropriate log levels
  - Remove unnecessary extension activation (Resources extension handles it)
- Update addService.ts to use context.ui.showInputBox/showQuickPick
  - Add vscode.l10n.t() to all user-facing strings
- Update extensions.ts to use context.ui.showInputBox
- Update Copilot instructions with UI best practices
  - Document l10n requirement for user-facing strings
  - Document context.ui usage instead of vscode.window
  - Note FileSystemWatcher scarcity

Author: spboyer

ext/vscode/.github/copilot-instructions.md

@@ -172,6 +172,14 @@ When working on `azure.yaml` language support in `src/language/`:
 - Use telemetry to measure and track performance metrics
 - Follow the patterns in `src/views/` for efficient tree providers
 
+### User Interface Best Practices
+- All user-facing strings shown in the UI, error messages, etc. must use `vscode.l10n.t()`
+- All user-facing strings in package.json must be extracted into package.nls.json
+- Instead of `vscode.window.showQuickPick`, use `IActionContext.ui.showQuickPick`
+- Instead of `vscode.window.showInputBox`, use `IActionContext.ui.showInputBox`
+- The same applies for `showWarningMessage`, `showOpenDialog`, and `showWorkspaceFolderPick`
+- FileSystemWatchers are a scarce resource on some systems - consolidate into shared watchers when possible
+
 ## Build & Package
 - Development build: `npm run dev-build`
 - Production build: `npm run build`

ext/vscode/src/commands/addService.ts

@@ -22,72 +22,60 @@ export async function addService(context: IActionContext, node?: AzureDevCliMode
     if (!documentUri) {
         const workspaceFolders = vscode.workspace.workspaceFolders;
         if (!workspaceFolders || workspaceFolders.length === 0) {
-            void vscode.window.showErrorMessage('No workspace folder is open.');
+            void vscode.window.showErrorMessage(vscode.l10n.t('No workspace folder is open.'));
             return;
         }
 
         // Search for azure.yaml or azure.yml files in workspace
         const azureYamlFiles = await vscode.workspace.findFiles('**/azure.{yml,yaml}', '**/node_modules/**', 1);
         if (azureYamlFiles.length === 0) {
-            void vscode.window.showErrorMessage('No azure.yaml file found in workspace.');
+            void vscode.window.showErrorMessage(vscode.l10n.t('No azure.yaml file found in workspace.'));
             return;
         }
 
         documentUri = azureYamlFiles[0];
     }
 
     // Prompt for service name
-    const serviceName = await vscode.window.showInputBox({
-        prompt: 'Enter service name',
+    const serviceName = await context.ui.showInputBox({
+        prompt: vscode.l10n.t('Enter service name'),
         placeHolder: 'api',
         validateInput: (value) => {
             if (!value || !/^[a-zA-Z0-9-_]+$/.test(value)) {
-                return 'Service name must contain only letters, numbers, hyphens, and underscores';
+                return vscode.l10n.t('Service name must contain only letters, numbers, hyphens, and underscores');
             }
             return undefined;
         }
     });
 
-    if (!serviceName) {
-        return;
-    }
-
     // Prompt for programming language
-    const language = await vscode.window.showQuickPick(
-        ['python', 'js', 'ts', 'csharp', 'java', 'go'],
-        { placeHolder: 'Select programming language' }
+    const language = await context.ui.showQuickPick(
+        ['python', 'js', 'ts', 'csharp', 'java', 'go'].map(lang => ({ label: lang })),
+        { placeHolder: vscode.l10n.t('Select programming language') }
     );
 
-    if (!language) {
-        return;
-    }
-
     // Prompt for Azure host
-    const host = await vscode.window.showQuickPick(
+    const host = await context.ui.showQuickPick(
         [
-            { label: 'containerapp', description: 'Azure Container Apps' },
-            { label: 'appservice', description: 'Azure App Service' },
-            { label: 'function', description: 'Azure Functions' }
+            { label: 'containerapp', description: vscode.l10n.t('Azure Container Apps') },
+            { label: 'appservice', description: vscode.l10n.t('Azure App Service') },
+            { label: 'function', description: vscode.l10n.t('Azure Functions') }
         ],
-        { placeHolder: 'Select Azure host' }
+        { placeHolder: vscode.l10n.t('Select Azure host') }
     );
 
-    if (!host) {
-        return;
-    }
-
     try {
         const document = await vscode.workspace.openTextDocument(documentUri);
         const text = document.getText();
         const doc = yaml.parseDocument(text);
 
         const services = doc.get('services') as yaml.YAMLMap;
         if (!services) {
-            void vscode.window.showErrorMessage('No services section found in azure.yaml');
+            void vscode.window.showErrorMessage(vscode.l10n.t('No services section found in azure.yaml'));
             return;
         }
 
-        const serviceSnippet = `\n  ${serviceName}:\n    project: ./${serviceName}\n    language: ${language}\n    host: ${host.label}`;
+        const serviceSnippet = `\n  ${serviceName}:\n    project: ./${serviceName}\n    language: ${language.label}\n    host: ${host.label}`;
 
         // Find the end of the services section
         if (doc.contents && yaml.isMap(doc.contents)) {
@@ -99,11 +87,11 @@ export async function addService(context: IActionContext, node?: AzureDevCliMode
                 const success = await vscode.workspace.applyEdit(edit);
 
                 if (success) {
-                    void vscode.window.showInformationMessage(`Service '${serviceName}' added to azure.yaml`);
+                    void vscode.window.showInformationMessage(vscode.l10n.t('Service \'{0}\' added to azure.yaml', serviceName));
                 }
             }
         }
     } catch (error) {
-        void vscode.window.showErrorMessage(`Failed to add service: ${error instanceof Error ? error.message : String(error)}`);
+        void vscode.window.showErrorMessage(vscode.l10n.t('Failed to add service: {0}', error instanceof Error ? error.message : String(error)));
     }
 }

ext/vscode/src/commands/azureWorkspace/wizard/RevealStep.ts

@@ -12,116 +12,66 @@ export class RevealStep extends AzureWizardExecuteStep<RevealResourceWizardConte
     public readonly priority: number = 100;
 
     public shouldExecute(wizardContext: RevealResourceWizardContext | RevealResourceGroupWizardContext): boolean {
-        const should = !!wizardContext.azureResourceId;
-        ext.outputChannel.appendLog(vscode.l10n.t('RevealStep shouldExecute: {0}, azureResourceId: {1}', should, wizardContext.azureResourceId || 'undefined'));
-        return should;
+        return !!wizardContext.azureResourceId;
     }
 
     public async execute(context: RevealResourceWizardContext | RevealResourceGroupWizardContext): Promise<void> {
-        ext.outputChannel.appendLog(vscode.l10n.t('RevealStep starting execute with azureResourceId: {0}', context.azureResourceId || 'undefined'));
         const azureResourceId = nonNullProp(context, 'azureResourceId');
-        ext.outputChannel.appendLog(vscode.l10n.t('Getting Azure Resource Extension API...'));
         const api = await getAzureResourceExtensionApi();
-        ext.outputChannel.appendLog(vscode.l10n.t('API obtained, focusing Azure Resources view...'));
 
         // Show the Azure Resources view first to ensure the reveal is visible
         await vscode.commands.executeCommand('azureResourceGroups.focus');
-        ext.outputChannel.appendLog(vscode.l10n.t('View focused'));
-
-        // Extract provider from resource ID to determine which extension to activate
-        const providerMatch = azureResourceId.match(/\/providers\/([^/]+)/i);
-        const provider = providerMatch ? providerMatch[1] : null;
-        ext.outputChannel.appendLog(vscode.l10n.t('Resource provider: {0}', provider || 'none'));
-
-        // Activate the appropriate Azure extension based on provider
-        if (provider) {
-            const extensionMap: Record<string, string> = {
-                // eslint-disable-next-line @typescript-eslint/naming-convention
-                'Microsoft.App': 'ms-azuretools.vscode-azurecontainerapps',
-                // eslint-disable-next-line @typescript-eslint/naming-convention
-                'Microsoft.Web': 'ms-azuretools.vscode-azurefunctions',
-                // eslint-disable-next-line @typescript-eslint/naming-convention
-                'Microsoft.Storage': 'ms-azuretools.vscode-azurestorage',
-                // eslint-disable-next-line @typescript-eslint/naming-convention
-                'Microsoft.DocumentDB': 'ms-azuretools.azure-cosmos',
-            };
-
-            const extensionId = extensionMap[provider];
-            if (extensionId) {
-                ext.outputChannel.appendLog(vscode.l10n.t('Activating extension: {0}', extensionId));
-                const extension = vscode.extensions.getExtension(extensionId);
-                if (extension && !extension.isActive) {
-                    await extension.activate();
-                    ext.outputChannel.appendLog(vscode.l10n.t('Extension activated'));
-                    // Delay to allow the extension to register its tree data provider.
-                    // The Azure Resources API doesn't provide an event for when provider registration completes.
-                    await new Promise(resolve => setTimeout(resolve, 1000));
-                }
-            }
-        }
-
-        ext.outputChannel.appendLog(vscode.l10n.t('Attempting reveal...'));
 
         try {
             // Try to refresh the Azure Resources view to ensure the tree is loaded
-            ext.outputChannel.appendLog(vscode.l10n.t('Refreshing Azure Resources tree...'));
             try {
                 await vscode.commands.executeCommand('azureResourceGroups.refresh');
-                ext.outputChannel.appendLog(vscode.l10n.t('Refresh command executed'));
                 // Delay to allow the tree to fully populate after refresh.
                 // The Azure Resources API doesn't expose an event for tree load completion,
                 // so we use a delay as a pragmatic workaround.
                 await new Promise(resolve => setTimeout(resolve, 1500));
             } catch (refreshError) {
-                ext.outputChannel.appendLog(vscode.l10n.t('Refresh command not available or failed: {0}', refreshError instanceof Error ? refreshError.message : String(refreshError)));
+                ext.outputChannel.debug(vscode.l10n.t('Refresh command not available or failed: {0}', refreshError instanceof Error ? refreshError.message : String(refreshError)));
             }
 
             // Extract subscription and resource group from the resource ID to reveal the RG first
             const resourceIdMatch = azureResourceId.match(/\/subscriptions\/([^/]+)\/resourceGroups\/([^/]+)/i);
             if (resourceIdMatch) {
                 const subscriptionId = resourceIdMatch[1];
                 const resourceGroupName = resourceIdMatch[2];
-                ext.outputChannel.appendLog(vscode.l10n.t('Subscription: {0}, Resource Group: {1}', subscriptionId, resourceGroupName));
 
                 // Try revealing the resource group first to ensure the tree is expanded
                 const rgResourceId = `/subscriptions/${subscriptionId}/resourceGroups/${resourceGroupName}`;
-                ext.outputChannel.appendLog(vscode.l10n.t('Revealing resource group first: {0}', rgResourceId));
                 try {
                     await api.resources.revealAzureResource(rgResourceId, { select: false, focus: false, expand: true });
                     // Delay to allow the tree node to expand before revealing the child resource.
                     // The revealAzureResource API returns before the tree UI fully updates.
                     await new Promise(resolve => setTimeout(resolve, 1000));
                 } catch (rgError) {
-                    ext.outputChannel.appendLog(vscode.l10n.t('Resource group reveal failed: {0}', rgError instanceof Error ? rgError.message : String(rgError)));
+                    ext.outputChannel.debug(vscode.l10n.t('Resource group reveal failed: {0}', rgError instanceof Error ? rgError.message : String(rgError)));
                 }
             }
 
-            ext.outputChannel.appendLog(vscode.l10n.t('Calling revealAzureResource with options: select=true, focus=true, expand=true'));
             const result = await api.resources.revealAzureResource(azureResourceId, { select: true, focus: true, expand: true });
-            ext.outputChannel.appendLog(vscode.l10n.t('revealAzureResource returned: {0}', String(result)));
 
             // Note: The focusGroup command to trigger "Focused Resources" view requires internal
             // tree item context that's not accessible through the public API. Users can manually
             // click the zoom-in icon on the resource group if they want the focused view.
 
             // Try a second time if needed
             if (result === undefined) {
-                ext.outputChannel.appendLog(vscode.l10n.t('First reveal returned undefined, trying again after delay...'));
                 // Retry delay: the first reveal may fail if the tree hasn't finished loading.
                 // A brief delay before retry often succeeds where the first attempt failed.
                 await new Promise(resolve => setTimeout(resolve, 1000));
                 const secondResult = await api.resources.revealAzureResource(azureResourceId, { select: true, focus: true, expand: true });
-                ext.outputChannel.appendLog(vscode.l10n.t('Second attempt returned: {0}', String(secondResult)));
 
                 // Try using the openInPortal command as an alternative
                 if (secondResult === undefined) {
-                    ext.outputChannel.appendLog(vscode.l10n.t('Reveal API not working as expected, trying alternative approach'));
                     // Try the workspace resource reveal command specific to this view
                     try {
                         await vscode.commands.executeCommand('azureResourceGroups.revealResource', azureResourceId);
-                        ext.outputChannel.appendLog(vscode.l10n.t('Alternative reveal command succeeded'));
                     } catch (altError) {
-                        ext.outputChannel.appendLog(vscode.l10n.t('Alternative reveal also failed: {0}', altError instanceof Error ? altError.message : String(altError)));
+                        ext.outputChannel.debug(vscode.l10n.t('Alternative reveal also failed: {0}', altError instanceof Error ? altError.message : String(altError)));
                         vscode.window.showInformationMessage(
                             vscode.l10n.t('Unable to automatically reveal resource in tree. Resource ID: {0}', azureResourceId),
                             vscode.l10n.t('Copy Resource ID'),
@@ -136,11 +86,8 @@ export class RevealStep extends AzureWizardExecuteStep<RevealResourceWizardConte
                     }
                 }
             }
-
-            ext.outputChannel.appendLog(vscode.l10n.t('revealAzureResource completed'));
         } catch (error) {
-            ext.outputChannel.appendLog(vscode.l10n.t('Failed to reveal resource: {0}', error instanceof Error ? error.message : String(error)));
-            // Show error to user
+            ext.outputChannel.error(vscode.l10n.t('Failed to reveal resource: {0}', error instanceof Error ? error.message : String(error)));
             vscode.window.showErrorMessage(vscode.l10n.t('Failed to reveal Azure resource: {0}', error instanceof Error ? error.message : String(error)));
             throw error;
         }

ext/vscode/src/commands/extensions.ts

@@ -71,15 +71,11 @@ export async function installExtension(context: IActionContext): Promise<void> {
         await runExtensionCommand(context, args, vscode.l10n.t('Adding extension source...'), TelemetryId.ExtensionSourceAddCli);
     }
 
-    const id = await vscode.window.showInputBox({
+    const id = await context.ui.showInputBox({
         prompt: vscode.l10n.t('Enter the ID of the extension to install'),
         placeHolder: vscode.l10n.t('Extension ID')
     });
 
-    if (!id) {
-        return;
-    }
-
     const args = composeArgs(
         withArg('extension', 'install'),
         withQuotedArg(id)
@@ -92,16 +88,12 @@ export async function uninstallExtension(context: IActionContext, item?: Extensi
     let id = item?.extension.id;
 
     if (!id) {
-        id = await vscode.window.showInputBox({
+        id = await context.ui.showInputBox({
             prompt: vscode.l10n.t('Enter the ID of the extension to uninstall'),
             placeHolder: vscode.l10n.t('Extension ID')
         });
     }
 
-    if (!id) {
-        return;
-    }
-
     const args = composeArgs(
         withArg('extension', 'uninstall'),
         withQuotedArg(id)
@@ -114,16 +106,12 @@ export async function upgradeExtension(context: IActionContext, item?: Extension
     let id = item?.extension.id;
 
     if (!id) {
-        id = await vscode.window.showInputBox({
+        id = await context.ui.showInputBox({
             prompt: vscode.l10n.t('Enter the ID of the extension to upgrade'),
             placeHolder: vscode.l10n.t('Extension ID')
         });
     }
 
-    if (!id) {
-        return;
-    }
-
     const args = composeArgs(
         withArg('extension', 'install'),
         withQuotedArg(id),