Migrate to use new shared eng package (#6600)

Author: bwateratmsft

.github/workflows/vscode-ci.yml

@@ -24,7 +24,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: "20"
+          node-version: "22"
       - run: npm install -g cspell@8.13.1
       - name: Spell check for vscode extension
         run: cspell lint '**/*.ts' --config ./ext/vscode/.vscode/cspell.yaml --root ./ext/vscode --no-progress
@@ -33,7 +33,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [20.x]
+        node-version: [22.x]
         os: [macos-latest, ubuntu-latest, windows-latest]
         include:
           - os: ubuntu-latest

eng/pipelines/templates/jobs/build-scan-vscode.yml

@@ -26,15 +26,15 @@ jobs:
           demands: ImageOverride -equals ${{ build.value.OSVmImage }}
 
       variables:
-        NodeVersion: 20.x
+        NodeVersion: 22.x
 
       steps:
         - task: NodeTool@0
           inputs:
             versionSpec: $(NodeVersion)
 
         - bash: |
-            npm install -g npm vsce
+            npm install -g npm @vscode/vsce
             npm ci --no-optional
           workingDirectory: ext/vscode
 

eng/pipelines/templates/jobs/vscode-build.yml

@@ -24,7 +24,7 @@ jobs:
       os: ${{ parameters.OS }}
 
     variables:
-      NodeVersion: 20.x
+      NodeVersion: 22.x
       ${{ insert }}: ${{ parameters.Variables }}
 
     steps:
@@ -34,7 +34,7 @@ jobs:
           versionSpec: $(NodeVersion)
 
       - pwsh: |
-          npm i -g npm vsce
+          npm i -g npm @vscode/vsce
           npm ci --no-optional
         workingDirectory: ext/vscode
         displayName: Install dependencies

ext/vscode/.vscode-test.mjs

@@ -0,0 +1,6 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See LICENSE.md in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+export { azExtSrcTestConfig as default } from '@microsoft/vscode-azext-eng/vscode-test'; // Other configurations exist

ext/vscode/.vscode/extensions.json

@@ -3,7 +3,7 @@
     // for the documentation about the extensions.json format
     "recommendations": [
         "dbaeumer.vscode-eslint",
-        "amodio.tsl-problem-matcher",
+        "connor4312.esbuild-problem-matchers",
         "streetsidesoftware.code-spell-checker"
     ]
 }

ext/vscode/.vscode/launch.json

@@ -6,22 +6,19 @@
     "version": "0.2.0",
     "configurations": [
         {
-            "name": "Run AZD Extension",
+            "name": "Run Extension",
             "type": "extensionHost",
             "request": "launch",
             "args": [
-                "--extensionDevelopmentPath=${workspaceFolder}"
+                "--extensionDevelopmentPath=${workspaceFolder}",
             ],
-            "preLaunchTask": "${defaultBuildTask}",
             "env": {
-                // Disable telemetry when running the extension under the debugger.
-                // Set this to "verbose" to show telemetry in the console during debugging.
-                "DEBUGTELEMETRY": "true"
+                "DEBUGTELEMETRY": "1",
             },
             "outFiles": [
-                "${workspaceFolder}/dist/**/*.js",
-                "${workspaceFolder}/*.js"
+                "${workspaceFolder}/dist/**/*.{js,mjs,cjs}",
             ],
+            "preLaunchTask": "Watch: ESBuild",
         },
         {
             "name": "Run AZD + Azure Resources Extensions",
@@ -31,36 +28,28 @@
                 "--extensionDevelopmentPath=${workspaceFolder}/../../../vscode-azureresourcegroups",
                 "--extensionDevelopmentPath=${workspaceFolder}",
             ],
-            "preLaunchTask": "${defaultBuildTask}",
             "env": {
-                // Disable telemetry when running the extension under the debugger.
-                // Set this to "verbose" to show telemetry in the console during debugging.
-                "DEBUGTELEMETRY": "true"
+                "DEBUGTELEMETRY": "1",
             },
             "outFiles": [
-                "${workspaceFolder}/dist/**/*.js",
-                "${workspaceFolder}/*.js",
-                "${workspaceFolder}/../../../vscode-azureresourcegroups/dist/**/*.js",
-                "${workspaceFolder}/../../../vscode-azureresourcegroups/*.js"
+                "${workspaceFolder}/dist/**/*.{js,mjs,cjs}",
+                "${workspaceFolder}/../../../vscode-azureresourcegroups/dist/**/*.{js,mjs,cjs}",
             ],
+            "preLaunchTask": "Watch: ESBuild",
         },
         {
-            "name": "Debug Unit Tests",
+            "name": "Run Tests",
             "type": "extensionHost",
             "request": "launch",
-            "args": [
-                "--extensionDevelopmentPath=${workspaceFolder}",
-                "--extensionTestsPath=${workspaceFolder}/out/test/suite/unitTests"
-            ],
+            "testConfiguration": "${workspaceFolder}/.vscode-test.mjs",
+            "env": {
+                "DEBUGTELEMETRY": "1",
+            },
             "outFiles": [
-                "${workspaceFolder}/out/test/**/*.js"
+                "${workspaceFolder}/dist/**/*.{js,mjs,cjs}",
+                "${workspaceFolder}/src/**/*.{ts,mts,cts}", // We are using TSX so out files *are* the source files
             ],
-            "preLaunchTask": "${defaultBuildTask}",
-            "env": {
-                // Disable test timeouts and telemetry when debugging tests.
-                "TEST_TIMEOUT": "0",
-                "DEBUGTELEMETRY": "true"
-            }
-        }
+            "preLaunchTask": "Watch: ESBuild",
+        },
     ]
 }

ext/vscode/.vscode/tasks.json

@@ -1,38 +1,46 @@
+// See https://go.microsoft.com/fwlink/?LinkId=733558
+// for the documentation about the tasks.json format
 {
     "version": "2.0.0",
     "tasks": [
         {
-            "label": "npm watch",
-            "type": "npm",
-            "script": "watch",
-            "problemMatcher": [
-                "$ts-webpack-watch",
-                "$tslint-webpack-watch"
+            "label": "Watch: ESBuild",
+            "type": "shell",
+            "command": "npm",
+            "args": [
+                "run",
+                "build:esbuild",
+                "--",
+                "--watch"
             ],
-            "isBackground": true,
+            "problemMatcher": "$esbuild-watch",
             "presentation": {
-                "reveal": "never"
+                "reveal": "silent",
             },
             "group": {
                 "kind": "build",
-                "isDefault": true
-            }
+            },
+            "isBackground": true,
         },
-
         {
-            "label": "npm dev-build",
-            "type": "npm",
-            "script": "dev-build",
-            "problemMatcher": [
-                "$ts-webpack-watch",
-                "$tslint-webpack-watch"
+            "label": "Watch: Check Types",
+            "type": "shell",
+            "command": "npm",
+            "args": [
+                "run",
+                "build:check",
+                "--",
+                "--watch"
             ],
+            "problemMatcher": "$tsc-watch",
             "presentation": {
-                "reveal": "never"
+                "revealProblems": "onProblem",
             },
             "group": {
-                "kind": "build"
-            }
-        }
-    ]
+                "kind": "build",
+                "isDefault": true,
+            },
+            "isBackground": true,
+        },
+    ],
 }

ext/vscode/.vscodeignore

@@ -18,3 +18,6 @@ webpack.config.js
 **/*.map
 **/*.ts
 **/*.ps1
+.vscode-test.mjs
+AGENTS.md
+esbuild.mjs

ext/vscode/ci-test.ps1

@@ -1,5 +1,5 @@
 if ($IsLinux) {
-    xvfb-run -a npm run unit-test
+    xvfb-run -a npm run ci-test
 } else {
-    npm run unit-test
+    npm run ci-test
 }

ext/vscode/esbuild.mjs

@@ -0,0 +1,7 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See LICENSE.md in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import { autoEsbuildOrWatch, autoSelectEsbuildConfig } from '@microsoft/vscode-azext-eng/esbuild';
+await autoEsbuildOrWatch(autoSelectEsbuildConfig());