Expose AddDurableTaskFactory methodss to .NET Framework release (#1653)

* Expose AddDurableTaskFactory methodss to .NET Framework release

Some customers with .NET Framework apps may be using the
IServiceCollection dependency injection model for their applications, so
these extension methods should be exposed for that scenario.

For a future release, we should expose a simple static method to create
an instance of IDurableClientFactory so .NET Framework apps using other
dependency injection methods can still take advantage of the new
external client work.

* Add PR number to release notes

Author: Connor McMahon

release_notes.md

@@ -1,12 +1,12 @@
 <!-- Please put your changes into the appropriate category (or categories) below. -->
 
 ## New Features
+- Exposed IServiceCollection extension methods AddDurableTaskFactory() for net461 releases so classic .NET Framework apps using the .NET Core model of dependency injection can create their own Durable Clients. (#1653)
 
 ## Bug fixes
 - Remove incorrect information from C# docs summary for IDurableEntityClient.ReadEntityStateAsync() regarding states large than 16KB (#1637)
 - Fix a NullReferenceException in IDurableClient.SignalClient() for IDurableClient objects created by the new DurabilityClientFactory (#1644)
 
-
 ## Breaking changes
 
 

src/WebJobs.Extensions.DurableTask/DurableTaskJobHostConfigurationExtensions.cs

@@ -13,8 +13,12 @@
 using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Options;
 #else
+using Microsoft.Azure.WebJobs.Extensions.DurableTask.ContextImplementations;
+using Microsoft.Azure.WebJobs.Extensions.DurableTask.Options;
 using Microsoft.Azure.WebJobs.Host;
 using Microsoft.Azure.WebJobs.Host.Config;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.DependencyInjection.Extensions;
 #endif
 
 namespace Microsoft.Azure.WebJobs.Extensions.DurableTask
@@ -24,36 +28,6 @@ namespace Microsoft.Azure.WebJobs.Extensions.DurableTask
     /// </summary>
     public static class DurableTaskJobHostConfigurationExtensions
     {
-#if !FUNCTIONS_V1
-        /// <summary>
-        /// Adds the Durable Task extension to the provided <see cref="IWebJobsBuilder"/>.
-        /// </summary>
-        /// <param name="builder">The <see cref="IWebJobsBuilder"/> to configure.</param>
-        /// <returns>Returns the provided <see cref="IWebJobsBuilder"/>.</returns>
-        public static IWebJobsBuilder AddDurableTask(this IWebJobsBuilder builder)
-        {
-            if (builder == null)
-            {
-                throw new ArgumentNullException(nameof(builder));
-            }
-
-            var serviceCollection = builder.AddExtension<DurableTaskExtension>()
-                .BindOptions<DurableTaskOptions>()
-                .Services.AddSingleton<IConnectionStringResolver, WebJobsConnectionStringProvider>();
-
-            serviceCollection.TryAddSingleton<IDurableHttpMessageHandlerFactory, DurableHttpMessageHandlerFactory>();
-            serviceCollection.TryAddSingleton<IDurabilityProviderFactory, AzureStorageDurabilityProviderFactory>();
-            serviceCollection.TryAddSingleton<IMessageSerializerSettingsFactory, MessageSerializerSettingsFactory>();
-            serviceCollection.TryAddSingleton<IErrorSerializerSettingsFactory, ErrorSerializerSettingsFactory>();
-            serviceCollection.TryAddSingleton<IApplicationLifetimeWrapper, HostLifecycleService>();
-#if !FUNCTIONS_V1
-            serviceCollection.AddSingleton<ITelemetryActivator, TelemetryActivator>();
-#endif
-            serviceCollection.TryAddSingleton<IDurableClientFactory, DurableClientFactory>();
-
-            return builder;
-        }
-
         /// <summary>
         /// Adds the Durable Task extension to the provided <see cref="IServiceCollection"/>.
         /// </summary>
@@ -88,6 +62,34 @@ public static IServiceCollection AddDurableClientFactory(this IServiceCollection
             return serviceCollection;
         }
 
+#if !FUNCTIONS_V1
+        /// <summary>
+        /// Adds the Durable Task extension to the provided <see cref="IWebJobsBuilder"/>.
+        /// </summary>
+        /// <param name="builder">The <see cref="IWebJobsBuilder"/> to configure.</param>
+        /// <returns>Returns the provided <see cref="IWebJobsBuilder"/>.</returns>
+        public static IWebJobsBuilder AddDurableTask(this IWebJobsBuilder builder)
+        {
+            if (builder == null)
+            {
+                throw new ArgumentNullException(nameof(builder));
+            }
+
+            var serviceCollection = builder.AddExtension<DurableTaskExtension>()
+                .BindOptions<DurableTaskOptions>()
+                .Services.AddSingleton<IConnectionStringResolver, WebJobsConnectionStringProvider>();
+
+            serviceCollection.TryAddSingleton<IDurableHttpMessageHandlerFactory, DurableHttpMessageHandlerFactory>();
+            serviceCollection.TryAddSingleton<IDurabilityProviderFactory, AzureStorageDurabilityProviderFactory>();
+            serviceCollection.TryAddSingleton<IMessageSerializerSettingsFactory, MessageSerializerSettingsFactory>();
+            serviceCollection.TryAddSingleton<IErrorSerializerSettingsFactory, ErrorSerializerSettingsFactory>();
+            serviceCollection.TryAddSingleton<IApplicationLifetimeWrapper, HostLifecycleService>();
+            serviceCollection.AddSingleton<ITelemetryActivator, TelemetryActivator>();
+            serviceCollection.TryAddSingleton<IDurableClientFactory, DurableClientFactory>();
+
+            return builder;
+        }
+
         /// <summary>
         /// Adds the Durable Task extension to the provided <see cref="IWebJobsBuilder"/>.
         /// </summary>

src/WebJobs.Extensions.DurableTask/Microsoft.Azure.WebJobs.Extensions.DurableTask.xml

@@ -11,7 +11,7 @@ namespace Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests
     /// Tests to make sure that calls to interface methods with closely related overloads
     /// do not change as we add/tweak methods on the interfaces.
     ///
-    /// TODO: Add more tests: https://github.com/Azure/azure-functions-durable-extension/issues/1500
+    /// TODO: Add more tests: https://github.com/Azure/azure-functions-durable-extension/issues/1500.
     /// </summary>
     public class InterfaceOverloadTests
     {