Analyzer: Excluded non-Function methods from BindingAnalyzer (#2244)

Author: amdeel

release_notes.md

@@ -7,4 +7,5 @@
 
 ## Dependencies
 - DurableTask.Core --> v2.10.*
-- DurableTask.AzureStorage --> v1.12.*
+- DurableTask.AzureStorage --> v1.12.*
+- DurableTask.Analyzers --> 0.5.0

src/WebJobs.Extensions.DurableTask.Analyzers/Analyzers/Orchestrator/BindingAnalyzer.cs

@@ -1,6 +1,7 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
+using System.Collections.Generic;
 using System.Linq;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
@@ -21,10 +22,15 @@ public class BindingAnalyzer
 
         public static readonly DiagnosticDescriptor Rule = new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, Severity, isEnabledByDefault: true);
 
-        public static bool RegisterDiagnostic(CompilationAnalysisContext context, SyntaxNode method)
+        public static bool RegisterDiagnostic(CompilationAnalysisContext context, SemanticModel semanticModel, SyntaxNode method)
         {
             var diagnosedIssue = false;
 
+            if (!SyntaxNodeUtils.IsInsideFunction(semanticModel, method))
+            {
+                return diagnosedIssue;
+            }
+
             var parameterList = method.ChildNodes().First(x => x.IsKind(SyntaxKind.ParameterList));
 
             foreach (SyntaxNode descendant in parameterList.DescendantNodes())

src/WebJobs.Extensions.DurableTask.Analyzers/Analyzers/Orchestrator/DeterministicMethodAnalyzer.cs

@@ -66,7 +66,7 @@ private void RegisterAnalyzers(CompilationAnalysisContext context)
                     | ThreadTaskAnalyzer.RegisterDiagnostic(context, semanticModel, methodDeclaration)
                     | TimerAnalyzer.RegisterDiagnostic(context, semanticModel, methodDeclaration)
                     | CancellationTokenAnalyzer.RegisterDiagnostic(context, methodDeclaration)
-                    | BindingAnalyzer.RegisterDiagnostic(context, methodDeclaration)
+                    | BindingAnalyzer.RegisterDiagnostic(context, semanticModel, methodDeclaration)
                     | DependencyInjectionAnalyzer.RegisterDiagnostic(context, methodDeclaration))
                 {
                     methodInvocationAnalyzer.RegisterDiagnostics(context, methodInformation);

test/WebJobs.Extensions.DurableTask.Analyzers.Test/Orchestrator/BindingAnalyzerTersts.cs

@@ -30,6 +30,11 @@ public static class HelloSequence
             [FunctionName(""BindingAnalyzerTestCases"")]
             public static async Task Run(
             [OrchestrationTrigger] IDurableOrchestrationContext context)
+            {
+                ExcludeNonFunctionsTest(""test"");
+            }
+
+            public void ExcludeNonFunctionsTest([NotNull] string input)
             {
             }
         }