Fixed returnInternalServerErrorOnFailure not working as expected (#1683)

* Fixed returnInternalServerErrorOnFailure parameter not being passed
* Adding test code for returnInternalServerErrorOnFailure

Author: shibayan

src/WebJobs.Extensions.DurableTask/ContextImplementations/DurableClient.cs

@@ -125,7 +125,7 @@ async Task<HttpResponseMessage> IDurableOrchestrationClient.WaitForCompletionOrC
         async Task<IActionResult> IDurableOrchestrationClient.WaitForCompletionOrCreateCheckStatusResponseAsync(HttpRequest request, string instanceId, TimeSpan? timeout, TimeSpan? retryInterval, bool returnInternalServerErrorOnFailure)
         {
             HttpRequestMessage requestMessage = ConvertHttpRequestMessage(request);
-            HttpResponseMessage responseMessage = await ((IDurableOrchestrationClient)this).WaitForCompletionOrCreateCheckStatusResponseAsync(requestMessage, instanceId, timeout, retryInterval);
+            HttpResponseMessage responseMessage = await ((IDurableOrchestrationClient)this).WaitForCompletionOrCreateCheckStatusResponseAsync(requestMessage, instanceId, timeout, retryInterval, returnInternalServerErrorOnFailure);
             return ConvertHttpResponseMessage(responseMessage);
         }
 

test/Common/DurableClientBaseTests.cs

@@ -255,9 +255,17 @@ public async Task HttpRequest_HttpRequestMessage_ClientMethods_Identical()
             HttpResponseMessage netCoreResponse = (HttpResponseMessage)((ObjectResult)durableOrchestrationClient.CreateCheckStatusResponse(netCoreRequest, sampleId)).Value;
             await AssertHttpResponsesEqual(netFrameworkResponse, netCoreResponse);
 
+            netFrameworkResponse = durableOrchestrationClient.CreateCheckStatusResponse(netFrameworkRequest, sampleId, returnInternalServerErrorOnFailure: true);
+            netCoreResponse = (HttpResponseMessage)((ObjectResult)durableOrchestrationClient.CreateCheckStatusResponse(netCoreRequest, sampleId, returnInternalServerErrorOnFailure: true)).Value;
+            await AssertHttpResponsesEqual(netFrameworkResponse, netCoreResponse);
+
             netFrameworkResponse = await durableOrchestrationClient.WaitForCompletionOrCreateCheckStatusResponseAsync(netFrameworkRequest, sampleId);
             netCoreResponse = (HttpResponseMessage)((ObjectResult)await durableOrchestrationClient.WaitForCompletionOrCreateCheckStatusResponseAsync(netCoreRequest, sampleId)).Value;
             await AssertHttpResponsesEqual(netFrameworkResponse, netCoreResponse);
+
+            netFrameworkResponse = await durableOrchestrationClient.WaitForCompletionOrCreateCheckStatusResponseAsync(netFrameworkRequest, sampleId, returnInternalServerErrorOnFailure: true);
+            netCoreResponse = (HttpResponseMessage)((ObjectResult)await durableOrchestrationClient.WaitForCompletionOrCreateCheckStatusResponseAsync(netCoreRequest, sampleId, returnInternalServerErrorOnFailure: true)).Value;
+            await AssertHttpResponsesEqual(netFrameworkResponse, netCoreResponse);
         }
 
         private static async Task<HttpRequest> ConvertHttpRequestMessageAsync(HttpRequestMessage req)