Skip to content

Commit eee1aee

Browse files
authored
Update ActivityInputConverter for Activities with FunctionContext-only parameters (#2806)
* Update ActivityInputConverter.cs * update result to unhandled
1 parent 95ede59 commit eee1aee

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

src/Worker.Extensions.DurableTask/ActivityInputConverter.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,13 @@ public ValueTask<ConversionResult> ConvertAsync(ConverterContext context)
2525
throw new ArgumentNullException(nameof(context));
2626
}
2727

28+
// Special handling for FunctionContext
29+
// This addresses cases where the activity function has only FunctionContext as a parameter.
30+
if (context.TargetType == typeof(FunctionContext))
31+
{
32+
return new(ConversionResult.Unhandled());
33+
}
34+
2835
if (context.Source is null)
2936
{
3037
return new(ConversionResult.Success(null));

src/Worker.Extensions.DurableTask/ActivityTriggerAttribute.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ namespace Microsoft.Azure.Functions.Worker;
1515
[AttributeUsage(AttributeTargets.Parameter)]
1616
[DebuggerDisplay("{Activity}")]
1717
[InputConverter(typeof(ActivityInputConverter))]
18-
[ConverterFallbackBehavior(ConverterFallbackBehavior.Disallow)]
18+
[ConverterFallbackBehavior(ConverterFallbackBehavior.Allow)]
1919
public sealed class ActivityTriggerAttribute : TriggerBindingAttribute
2020
{
2121
/// <summary>

0 commit comments

Comments
 (0)