Durable Entity Locking and Calling Activities

[cliedeman]

It is not 100% clear from the docs if the below code is best practice/supported.
https://learn.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-entities?tabs=class-based%2Cisolated-process%2Cpython-v2&pivots=csharp#critical-section-behavior

    [Function(nameof(MyOrchestrator))]
    public static async Task MyOrchestrator(
        [OrchestrationTrigger] TaskOrchestrationContext context,
        Guid input)
    {
        var lockEntity = new EntityInstanceId(nameof(LockEntity), input.ToString());

        await using (await context.Entities.LockEntitiesAsync(lockEntity))
        {
            // is this safe?
            await context.CallActivity1Async(input);
            await context.CallActivity2Async(input);
        }
    }

    [Function(nameof(LockEntity))]
    public static Task RunEntityAsync([EntityTrigger] TaskEntityDispatcher dispatcher)
    {
        return dispatcher.DispatchAsync<LockEntity>();
    }

I could move the activity code inside the durable entity but our use is locking critical sections across different orchestrators to avoid race conditions

Ciaran

[cgillum]

Calling activities from critical sections is totally fine.

/cc @sebastianburckhardt