-
Notifications
You must be signed in to change notification settings - Fork 286
Open
Labels
Description
Summary
The e2e tests for client operation logging correlation (PR #3326) currently have conditional assertions that skip validation if the ClientOperationReceived logs are not present. This is necessary because the .NET Isolated SDK changes that propagate the FunctionInvocationId header are in a separate PR and have not been released yet.
Background
Issue #3317 adds correlation between out-of-process worker function invocations and host-side orchestration events by:
- Host extension logs ClientOperationReceived when it receives a client operation with a FunctionInvocationId header/metadata
- SDKs (.NET Isolated, Python, Java, JavaScript) send the FunctionInvocationId in HTTP headers or gRPC metadata
The e2e tests run against published NuGet packages, which do not have the SDK changes yet.
Action Required
Once the following SDK PRs are merged and released:
- .NET Isolated: Part of PR Add FunctionInvocationId correlation for client operations #3326 (same repo)
- Python: Add FunctionInvocationId header propagation for client operations azure-functions-durable-python#593
- Java: Add FunctionInvocationId gRPC metadata propagation for Azure Functions microsoft/durabletask-java#252
- JavaScript: Add FunctionInvocationId header propagation for client operations azure-functions-durable-js#672
Update these files to remove the conditional checks and make the assertions mandatory:
- test/e2e/Tests/Helpers/ClientOperationLogHelpers.cs - Remove the if (hasClientOperationLog) conditional
- test/e2e/Tests/Tests/RewindOrchestratorTests.cs - Remove the if (rewindLogCount > 0) conditional
Related
- Add logging to correlate client operations from workers to host logs #3317 - Original feature request
- Add FunctionInvocationId correlation for client operations #3326 - Implementation PR