More linter fixes

Author: andystaples

azure/durable_functions/models/DurableOrchestrationContext.py

@@ -51,8 +51,9 @@ class DurableOrchestrationContext:
     def __init__(self,
                  history: List[Dict[Any, Any]], instanceId: str, isReplaying: bool,
                  parentInstanceId: str, input: Any = None, upperSchemaVersion: int = 0,
-                 maximumShortTimerDuration:str = None, longRunningTimerIntervalDuration:str = None,
-                 upperSchemaVersionNew:int = None, **kwargs):
+                 maximumShortTimerDuration: str = None, 
+                 longRunningTimerIntervalDuration: str = None, upperSchemaVersionNew: int = None,
+                 **kwargs):
         self._histories: List[HistoryEvent] = [HistoryEvent(**he) for he in history]
         self._instance_id: str = instanceId
         self._is_replaying: bool = isReplaying
@@ -628,14 +629,14 @@ def create_timer(self, fire_at: datetime.datetime) -> TaskBase:
         if self._replay_schema.value >= ReplaySchema.V3.value:
             if not self.maximum_short_timer_duration or not self.long_timer_interval_duration:
                 raise Exception(
-                    "A framework-internal error was detected: " +
-                        "replay schema version >= V3 is being used, " +
-                        "but one or more of the properties `maximumShortTimerDuration`" +
-                        "and `longRunningTimerIntervalDuration` are not defined. " +
-                        "This is likely an issue with the Durable Functions Extension. " +
-                        "Please report this bug here: " + 
-                        "https://github.com/Azure/azure-functions-durable-python/issues\n" +
-                        f"maximumShortTimerDuration: {self.maximum_short_timer_duration}\n" +
+                    "A framework-internal error was detected: "\
+                        "replay schema version >= V3 is being used, "\
+                        "but one or more of the properties `maximumShortTimerDuration`"\
+                        "and `longRunningTimerIntervalDuration` are not defined. "\
+                        "This is likely an issue with the Durable Functions Extension. "\
+                        "Please report this bug here: "\
+                        "https://github.com/Azure/azure-functions-durable-python/issues\n"\
+                        f"maximumShortTimerDuration: {self.maximum_short_timer_duration}\n"\
                         f"longRunningTimerIntervalDuration: {self.long_timer_interval_duration}"
                 )
             if fire_at > self.current_utc_datetime + self.maximum_short_timer_duration:
@@ -718,7 +719,7 @@ def _add_to_actions(self, action_repr: Union[List[Action], Action]):
 
         if self._replay_schema is ReplaySchema.V1 and isinstance(action_repr, list):
             self._action_payload_v1.append(action_repr)
-        elif (self._replay_schema.value >= ReplaySchema.V2.value 
+        elif (self._replay_schema.value >= ReplaySchema.V2.value
               and isinstance(action_repr, Action)):
             self._action_payload_v2.append(action_repr)
         else:

azure/durable_functions/models/Task.py

@@ -377,8 +377,8 @@ def cancel(self):
     def try_set_value(self, child: TimerTask):
         """Transition this LongTimer Task to a terminal state and set its value.
 
-        If the LongTimer has not yet reached the designated completion time, starts a new 
-        TimerTask for the next interval and does not close. 
+        If the LongTimer has not yet reached the designated completion time, starts a new
+        TimerTask for the next interval and does not close.
 
         Parameters
         ----------
@@ -392,8 +392,8 @@ def try_set_value(self, child: TimerTask):
             self.add_new_child(next_timer)
         return super().try_set_value(child)
 
-    def get_next_timer_task(self, final_fire_time: datetime, current_time: datetime) -> TimerTask: 
-        """Creates a TimerTask that represents the next interval of the LongTimer
+    def get_next_timer_task(self, final_fire_time: datetime, current_time: datetime) -> TimerTask:
+        """Creates a TimerTask that represents the next interval of the LongTimer.
 
         Parameters
         ----------
@@ -415,7 +415,9 @@ def get_next_timer_task(self, final_fire_time: datetime, current_time: datetime)
         return TimerTask(None, CreateTimerAction(next_fire_time))
 
     def add_new_child(self, child_timer: TimerTask):
-        """Adds the TimerTask to this Task's children and schedules it in the orchestrationcontext
+        """Add the TimerTask to this task's children.
+        
+        Also register the TimerTask with the orchestration context.
 
         Parameters
         ----------
@@ -428,6 +430,7 @@ def add_new_child(self, child_timer: TimerTask):
         self.orchestration_context._add_to_actions(child_timer.action_repr)
         child_timer._set_is_scheduled(True)
 
+
 class WhenAnyTask(CompoundTask):
     """A Task representing `when_any` scenarios."""
 

azure/durable_functions/models/utils/json_utils.py

@@ -38,13 +38,14 @@ def add_datetime_attrib(json_dict: Dict[str, Any], object_,
         json_dict[alt_name or attribute_name] = \
             getattr(object_, attribute_name).strftime(DATETIME_STRING_FORMAT)
 
-# When we recieve properties from WebJobs extension originally parsed as 
-#   TimeSpan objects through Newtonsoft, the format complies with the constant 
+
+# When we recieve properties from WebJobs extension originally parsed as
+#   TimeSpan objects through Newtonsoft, the format complies with the constant
 #   format specifier for TimeSpan in .NET.
-#   Python offers no convenient way to parse these back into timedeltas, 
+#   Python offers no convenient way to parse these back into timedeltas,
 #   so we use this regex method instead
 def parse_timespan_attrib(from_str: str) -> datetime.timedelta:
-    """Converts a string representing TimeSpan.ToString("c") in .NET to python timespan.timedelta
+    """Convert a string representing TimeSpan.ToString("c") in .NET to a python timedelta.
 
     Parameters
     ----------
@@ -60,12 +61,12 @@ def parse_timespan_attrib(from_str: str) -> datetime.timedelta:
     match = re.match(expr, from_str)
     if match:
         span = datetime.timedelta(
-            days=int(match.group(2) or "0"), 
-            hours=int(match.group(3)), 
-            minutes=int(match.group(4)), 
-            seconds=int(match.group(5)), 
+            days=int(match.group(2) or "0"),
+            hours=int(match.group(3)),
+            minutes=int(match.group(4)),
+            seconds=int(match.group(5)),
             microseconds=int(match.group(6) or "0") // 10)
-        
+
         if match.group(1):
             span = -span
         return span