Detect sub-task completion in constructor (#391)

Author: davidmrdavid

azure/durable_functions/models/Task.py

@@ -171,6 +171,11 @@ def __init__(self, tasks: List[TaskBase], compound_action_constructor=None):
         if len(self.children) == 0:
             self.state = TaskState.SUCCEEDED
 
+        # Sub-tasks may have already completed, so we process them
+        for child in self.children:
+            if not(child.state is TaskState.RUNNING):
+                self.handle_completion(child)
+
     def handle_completion(self, child: TaskBase):
         """Manage sub-task completion events.
 

tests/orchestrator/test_sequential_orchestrator.py

@@ -24,6 +24,15 @@ def generator_function(context):
 
     return outputs
 
+def generator_function_multi_yield_when_all(context):
+    outputs = []
+
+    task1 = context.call_activity("Hello", "Tokyo")
+    yield context.task_all([task1])
+    result = yield context.task_all([task1])
+
+    return result
+
 def generator_function_is_replaying(context):
     outputs = []
 
@@ -297,6 +306,22 @@ def test_tokyo_and_seattle_and_london_state():
     assert_valid_schema(result)
     assert_orchestration_state_equals(expected, result)
 
+def test_multi_when_all_yield():
+    context_builder = ContextBuilder('test_simple_function')
+    add_hello_completed_events(context_builder, 0, "\"Hello Tokyo!\"")
+
+    result = get_orchestration_state_result(
+        context_builder, generator_function_multi_yield_when_all)
+
+    expected_state = base_expected_state(
+        ['Hello Tokyo!'])
+    add_hello_action(expected_state, 'Tokyo')
+    expected_state._is_done = True
+    expected = expected_state.to_json()
+
+    assert_valid_schema(result)
+    assert_orchestration_state_equals(expected, result)
+
 def test_sequential_is_replaying():
     context_builder = ContextBuilder('test_simple_function', is_replaying=True)
     add_hello_completed_events(context_builder, 0, "\"Hello Tokyo!\"", True)