Add unit test for FunctionEnvironmentReloadRequest (#4580)

Author: pragnagopa

src/WebJobs.Script/Rpc/LanguageWorkerChannel.cs

@@ -222,19 +222,26 @@ public Task SendFunctionEnvironmentReloadRequest()
 
             IDictionary processEnv = Environment.GetEnvironmentVariables();
 
-            FunctionEnvironmentReloadRequest request = new FunctionEnvironmentReloadRequest();
-            foreach (DictionaryEntry entry in processEnv)
-            {
-                request.EnvironmentVariables.Add(entry.Key.ToString(), entry.Value.ToString());
-            }
+            FunctionEnvironmentReloadRequest request = GetFunctionEnvironmentReloadRequest(processEnv);
 
             SendStreamingMessage(new StreamingMessage
             {
                 FunctionEnvironmentReloadRequest = request
             });
+
             return _reloadTask.Task;
         }
 
+        internal FunctionEnvironmentReloadRequest GetFunctionEnvironmentReloadRequest(IDictionary processEnv)
+        {
+            FunctionEnvironmentReloadRequest request = new FunctionEnvironmentReloadRequest();
+            foreach (DictionaryEntry entry in processEnv)
+            {
+                request.EnvironmentVariables.Add(entry.Key.ToString(), entry.Value.ToString());
+            }
+            return request;
+        }
+
         internal void SendFunctionLoadRequest(FunctionMetadata metadata)
         {
             _workerChannelLogger.LogDebug("Sending FunctionLoadRequest for function:{functionName} with functionId:{id}", metadata.Name, metadata.FunctionId);
@@ -257,7 +264,7 @@ internal FunctionLoadRequest GetFunctionLoadRequest(FunctionMetadata metadata)
                     Directory = metadata.FunctionDirectory ?? string.Empty,
                     EntryPoint = metadata.EntryPoint ?? string.Empty,
                     ScriptFile = metadata.ScriptFile ?? string.Empty,
-                    IsProxy = metadata.IsProxy,
+                    IsProxy = metadata.IsProxy
                 }
             };
 

test/WebJobs.Script.Tests/Rpc/LanguageWorkerChannelTests.cs

@@ -108,6 +108,31 @@ public void SendLoadRequests_PublishesOutboundEvents()
             Assert.True(functionLoadLogs.Count() == 2);
         }
 
+        [Fact]
+        public void SendSendFunctionEnvironmentReloadRequest_PublishesOutboundEvents()
+        {
+            Environment.SetEnvironmentVariable("TestNull", null);
+            Environment.SetEnvironmentVariable("TestEmpty", string.Empty);
+            Environment.SetEnvironmentVariable("TestValid", "TestValue");
+            _workerChannel.SendFunctionEnvironmentReloadRequest();
+            var traces = _logger.GetLogMessages();
+            var functionLoadLogs = traces.Where(m => string.Equals(m.FormattedMessage, "Sending FunctionEnvironmentReloadRequest"));
+            Assert.True(functionLoadLogs.Count() == 1);
+        }
+
+        [Fact]
+        public void SendSendFunctionEnvironmentReloadRequest_SanitizedEnvironmentVariables()
+        {
+            Environment.SetEnvironmentVariable("TestNull", null);
+            Environment.SetEnvironmentVariable("TestEmpty", string.Empty);
+            Environment.SetEnvironmentVariable("TestValid", "TestValue");
+            FunctionEnvironmentReloadRequest envReloadRequest = _workerChannel.GetFunctionEnvironmentReloadRequest(Environment.GetEnvironmentVariables());
+            Assert.False(envReloadRequest.EnvironmentVariables.ContainsKey("TestNull"));
+            Assert.False(envReloadRequest.EnvironmentVariables.ContainsKey("TestEmpty"));
+            Assert.True(envReloadRequest.EnvironmentVariables.ContainsKey("TestValid"));
+            Assert.True(envReloadRequest.EnvironmentVariables["TestValid"] == "TestValue");
+        }
+
         [Fact]
         public void ReceivesInboundEvent_InvocationResponse()
         {