Hotfix 4.1041.200 (#11176)

* Update version to 4.1041.200

* Clear release notes

* Handles loading extensions.json with empty extensions (#11174)

* Handle empty extensions array usecase.

* release notes.

* Liniting - remove empty line.

* Fixed typo in test comment.

* Update test/WebJobs.Script.Tests/ScriptStartupTypeDiscovererTests.cs

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Azure Functions Release <[email protected]>
Co-authored-by: Copilot <[email protected]>

Author: 3 people

release_notes.md

@@ -1,23 +1,6 @@
+### Release notes
+
 <!-- Please add your release notes in the following format:
 - My change description (#PR)
 -->
-- Memory allocation optimizations in `ScriptStartupTypeLocator.GetExtensionsStartupTypesAsync` (#11012)
-- Fix invocation timeout when incoming request contains "x-ms-invocation-id" header (#10980)
-- Warn if .azurefunctions folder does not exist (#10967)
-- Memory allocation & CPU optimizations in `GrpcMessageExtensionUtilities.ConvertFromHttpMessageToExpando` (#11054)
-- Replace `Timer` with `while`-loop in `FlexConsumptionMetricsPublisher` (#11071)
-- Memory allocation optimizations in `ReadLanguageWorkerFile` by reading files in buffered chunks, preventing LOH allocations (#11069)
-- Enhancing the capability to send startup failure logs to AppInsights/Otel. (#11055)
-- Added support for collecting cross-platform perf traces and generating PGO JIT traces (#11062)
-- Memory allocation optimizations in `DependencyHelper.GetExtensionRequirements` (#11022)
-- Fix Instance Manager for CV1 Migration (#11072)
-- Avoid setting up OTel and AzMon exporter in the placeholder mode. (#11090)
-- Memory allocation optimizations in `FeatureFlags.IsEnabled` by adopting zero-allocation `ContainsToken` for efficient delimited token search (#11075)
-- Improvements to coldstart pipeline (#11102).
-- Update Python Worker Version to [4.38.0](https://github.com/Azure/azure-functions-python-worker/releases/tag/4.38.0)
-- Only start the Diagnostic Events flush logs timer when events are present, preventing unnecessary flush attempts (#11100).
-- Enable HTTP proxying for custom handlers (#11035)
-- Switched memory usage reporting to use CGroup metrics by default for Linux consumption (#11114)
-- Update Java Worker Version to [2.19.2](https://github.com/Azure/azure-functions-java-worker/releases/tag/2.19.2)
-- Make serialization case insensitive (#11123)
-- Add JitTrace Files for v4.1041
+- Handles loading extensions.json with empty extensions(#11174)

src/Directory.Version.props

@@ -1,6 +1,6 @@
 <Project>
   <PropertyGroup>
-    <VersionPrefix>4.1041.100</VersionPrefix>
+    <VersionPrefix>4.1041.200</VersionPrefix>
     <UpdateBuildNumber>true</UpdateBuildNumber>
   </PropertyGroup>
 </Project>

src/WebJobs.Script/DependencyInjection/ScriptStartupTypeLocator.cs

@@ -235,7 +235,7 @@ private async Task<ExtensionReference[]> ParseExtensionsAsync(string metadataFil
                     await using var stream = File.OpenRead(metadataFilePath);
                     var extensionReferences = await JsonSerializer.DeserializeAsync(stream, ExtensionReferencesJsonContext.Default.ExtensionReferences);
 
-                    if (extensionReferences?.Extensions == null || extensionReferences.Extensions.Length == 0)
+                    if (extensionReferences?.Extensions == null)
                     {
                         _logger.ScriptStartUpUnableParseMetadataMissingProperty(metadataFilePath);
                         return [];

test/WebJobs.Script.Tests/ScriptStartupTypeDiscovererTests.cs

@@ -182,6 +182,7 @@ public async Task GetExtensionsStartupTypes_AcceptsRequiredBundleVersions(string
                     Assert.True(traces.Any(m => m.FormattedMessage.Contains($"Loading extension bundle")));
                 }
                 Assert.True(traces.Any(m => m.FormattedMessage.Contains($"Loading startup extension 'Storage")));
+                AssertNoErrors(traces);
             }
         }
 
@@ -310,6 +311,7 @@ public async Task GetExtensionsStartupTypes_AcceptsRequiredExtensionVersions(str
                 {
                     Assert.True(traces.Any(m => m.FormattedMessage.Contains($"Loading startup extension 'Storage")));
                 }
+                AssertNoErrors(traces);
             }
         }
 
@@ -423,6 +425,7 @@ void CopyToBin(string path)
                 Assert.Equal(typeof(AzureStorageWebJobsStartup).FullName, types.Single().FullName);
                 Assert.True(traces.Any(m => string.Equals(m.FormattedMessage, $"The extension startup type '{references[0].TypeName}' belongs to a builtin extension")));
                 Assert.True(traces.Any(m => string.Equals(m.FormattedMessage, $"The extension startup type '{references[1].TypeName}' belongs to a builtin extension")));
+                AssertNoErrors(traces);
             }
         }
 
@@ -516,6 +519,7 @@ void CopyToBin(string path)
                 Assert.Equal(typeof(AzureStorageWebJobsStartup).FullName, types.Single().FullName);
                 Assert.True(traces.Any(m => string.Equals(m.FormattedMessage, $"The extension startup type '{references[0].TypeName}' belongs to a builtin extension")));
                 Assert.True(traces.Any(m => string.Equals(m.FormattedMessage, $"The extension startup type '{references[1].TypeName}' belongs to a builtin extension")));
+                AssertNoErrors(traces);
             }
         }
 
@@ -592,11 +596,13 @@ void CopyToBin(string path)
 
                 // Act
                 var types = await discoverer.GetExtensionsStartupTypesAsync();
+                var traces = testLoggerProvider.GetAllLogMessages();
 
                 // Assert
                 AreExpectedMetricsGenerated(testMetricsLogger);
                 Assert.Equal(types.Count(), 2);
                 Assert.Equal(typeof(AzureStorageWebJobsStartup).FullName, types.FirstOrDefault().FullName);
+                AssertNoErrors(traces);
             }
         }
 
@@ -644,11 +650,13 @@ void CopyToBin(string path)
 
                 // Act
                 var types = await discoverer.GetExtensionsStartupTypesAsync();
+                var traces = testLoggerProvider.GetAllLogMessages();
 
                 // Assert
                 AreExpectedMetricsGenerated(testMetricsLogger);
                 Assert.Single(types);
                 Assert.Equal(typeof(AzureStorageWebJobsStartup).FullName, types.Single().FullName);
+                AssertNoErrors(traces);
             }
         }
 
@@ -698,11 +706,13 @@ void CopyToBin(string path)
 
                 // Act
                 var types = await discoverer.GetExtensionsStartupTypesAsync();
+                var traces = testLoggerProvider.GetAllLogMessages();
 
                 //Assert
                 AreExpectedMetricsGenerated(testMetricsLogger);
                 Assert.Single(types);
                 Assert.Equal(typeof(AzureStorageWebJobsStartup).FullName, types.Single().FullName);
+                AssertNoErrors(traces);
             }
         }
 
@@ -1144,13 +1154,55 @@ void CopyToBin(string path)
 
                 // Act
                 var types = await discoverer.GetExtensionsStartupTypesAsync();
+                var traces = testLoggerProvider.GetAllLogMessages();
                 Environment.SetEnvironmentVariable(EnvironmentSettingNames.AzureWebJobsFeatureFlags, null);
                 Environment.SetEnvironmentVariable(EnvironmentSettingNames.FunctionWorkerRuntime, null);
 
                 //Assert that filtering did not take place because of worker indexing
                 Assert.True(types.Count() == 1);
                 Assert.Equal(typeof(AzureStorageWebJobsStartup).FullName, types.ElementAt(0).FullName);
+                AssertNoErrors(traces);
+            }
+        }
+
+        [Fact]
+        public async Task GetExtensionsStartupTypes_EmptyExtensionsArray()
+        {
+            TestMetricsLogger testMetricsLogger = new TestMetricsLogger();
+
+            using var directory = new TempDirectory();
+            var binPath = Path.Combine(directory.Path, "bin");
+            Directory.CreateDirectory(binPath);
+
+            // extensions.json file with an empty extensions array (simulating extensions.json produced by in-proc app)
+            string extensionJson = """
+            {
+              "extensions": []
             }
+            """;
+            File.WriteAllText(Path.Combine(binPath, "extensions.json"), extensionJson);
+
+            TestLoggerProvider testLoggerProvider = new TestLoggerProvider();
+            LoggerFactory factory = new LoggerFactory();
+            factory.AddProvider(testLoggerProvider);
+            var testLogger = factory.CreateLogger<ScriptStartupTypeLocator>();
+
+            var mockExtensionBundleManager = new Mock<IExtensionBundleManager>();
+            mockExtensionBundleManager.Setup(e => e.IsExtensionBundleConfigured()).Returns(true);
+            mockExtensionBundleManager.Setup(e => e.GetExtensionBundleDetails()).Returns(Task.FromResult(new ExtensionBundleDetails() { Id = "bundleID", Version = "1.0.0" }));
+            mockExtensionBundleManager.Setup(e => e.GetExtensionBundleBinPathAsync()).Returns(Task.FromResult(binPath));
+
+            var languageWorkerOptions = new TestOptionsMonitor<LanguageWorkerOptions>(new LanguageWorkerOptions());
+            var mockFunctionMetadataManager = GetTestFunctionMetadataManager(languageWorkerOptions);
+            OptionsWrapper<ExtensionRequirementOptions> optionsWrapper = new(new ExtensionRequirementOptions());
+            var discoverer = new ScriptStartupTypeLocator(directory.Path, testLogger, mockExtensionBundleManager.Object, mockFunctionMetadataManager, testMetricsLogger, optionsWrapper);
+
+            var types = await discoverer.GetExtensionsStartupTypesAsync();
+            var traces = testLoggerProvider.GetAllLogMessages();
+
+            AreExpectedMetricsGenerated(testMetricsLogger);
+            Assert.Empty(types); // Ensure no types are loaded because the extensions array is empty
+            AssertNoErrors(traces);
         }
 
         private IFunctionMetadataManager GetTestFunctionMetadataManager(IOptionsMonitor<LanguageWorkerOptions> options, ICollection<FunctionMetadata> metadataCollection = null, bool hasPrecompiledFunction = false, bool hasNodeFunctions = false, bool hasDotnetIsolatedFunctions = false)
@@ -1234,5 +1286,10 @@ private ILogger<ScriptStartupTypeLocator> GetTestLogger()
             var testLogger = factory.CreateLogger<ScriptStartupTypeLocator>();
             return testLogger;
         }
+
+        private static void AssertNoErrors(IList<LogMessage> traces)
+        {
+            Assert.False(traces.Any(m => m.Level == LogLevel.Error || m.Level == LogLevel.Critical));
+        }
     }
 }