removing duplicate Exception logging in ILogger

Author: brettsam

src/WebJobs.Script/Host/ScriptHost.cs

@@ -1178,7 +1178,7 @@ private Collection<FunctionMetadata> LoadProxyRoutes(string proxiesJson)
                 {
                     _proxyClient = new ProxyClientExecutor(rawProxyClient);
                 }
-             }
+            }
 
             if (_proxyClient == null)
             {
@@ -1733,7 +1733,7 @@ private void HandleHostError(Exception exception)
             TraceWriter.Error(message, exception);
             TraceWriter.Flush();
 
-            Logger?.LogError(0, exception, message);
+            // Note: We do not log to ILogger here as any error has already been logged.
 
             if (exception is FunctionInvocationException)
             {

test/WebJobs.Script.Tests.Integration/ApplicationInsights/ApplicationInsightsEndToEndTestsBase.cs

@@ -183,17 +183,11 @@ private string ValidateEndToEndTest(string functionName, string functionTrace, b
 
                 ValidateTrace(errorTrace, $"Exception while executing function: Functions.{functionName}.", LogCategories.Executor, functionName, invocationId, SeverityLevel.Error);
 
-                ExceptionTelemetry[] exception = _fixture.Channel.Telemetries
+                ExceptionTelemetry exception = _fixture.Channel.Telemetries
                     .OfType<ExceptionTelemetry>()
-                    .Where(t => t.Context.Operation.Id == invocationId)
-                    .OrderBy(t => t.Message)
-                    .ToArray();
-
-                // We should only be logging one Exception. Tracked by https://github.com/Azure/azure-webjobs-sdk-script/issues/1830
-                Assert.Equal(2, exception.Length);
+                    .Single(t => t.Context.Operation.Id == invocationId);
 
-                ValidateException(exception[0], invocationId, functionName, LogCategories.Results);
-                ValidateException(exception[1], invocationId, functionName, ScriptConstants.LogCategoryHostGeneral);
+                ValidateException(exception, invocationId, functionName, LogCategories.Results);
             }
 
             RequestTelemetry requestTelemetry = _fixture.Channel.Telemetries