node case insensitive headers

Author: Matt Mason

WebJobs.Script.proj

@@ -178,7 +178,7 @@
     <BuildConfiguration Condition=" $(Configuration) != '' ">$(Configuration)</BuildConfiguration>
   </PropertyGroup>
 
-  <Target Name="MochaTest" DependsOnTargets="Build" AfterTargets="UnitTest">
+  <Target Name="MochaTest" DependsOnTargets="TestBuild" AfterTargets="UnitTest">
     <Exec Command="npm i mocha chai $(AppveyorModules)" />
     <Exec Command=".\node_modules\.bin\mocha .\test\WebJobs.Script.Tests\TestScripts\Node\*.tests.js $(AppveyorReporter) --config=$(BuildConfiguration)" />
   </Target>

src/WebJobs.Script/Content/Script/http/request.js

@@ -3,6 +3,6 @@
 
 module.exports = (context) => {
     var req = context.req;
-    req.get = (field) => req.headers[field];
+    req.get = (field) => req.headers[field.toLowerCase()];
     return req;
 };

src/WebJobs.Script/Content/Script/http/response.js

@@ -6,50 +6,73 @@ module.exports = (context) => {
         headers: {},
         body: undefined,
 
+        // functions methods
+        raw: (body) => {
+            res.isRaw = true;
+            return res.send(body);
+        },
+
+        // node httpResponse methods
+        setHeader: (field, val) => {
+            res.headers[field.toLowerCase()] = val;
+            return res;
+        },
+
+        getHeader: (field) => {
+            return res.headers[field.toLowerCase()];
+        },
+
+        removeHeader: (field) => {
+            delete res.headers[field.toLowerCase()];
+            return res;
+        },
+
         end: (body) => {
             if (body !== undefined) {
                 res.body = body;
             }
+            setContentType(res);
             context.done();
             return res;
         },
 
+        // express methods
         status: (statusCode) => {
             res.statusCode = statusCode;
             return res;
         },
 
-        set: (field, val) => {
-            res.headers[field] = val;
-            return res;
-        },
-
         sendStatus: (statusCode) => {
             return res.status(statusCode)
                 .end();
         },
 
         type: (type) => {
-            return res.set('Content-Type', type);
+            return res.set('content-type', type);
         },
 
         json: (body) => {
             return res.type('application/json')
                 .send(body);
-        },
-
-        raw: (body) => {
-            res.isRaw = true;
-            return res.send(body);
-        },
-
-        get: (field) => {
-            return res.headers[field]
         }
     };
 
     res.send = res.end;
-    res.header = res.set;
+    res.header = res.set = res.setHeader;
+    res.get = res.getHeader;
 
     return res;
 };
+
+function setContentType(res) {
+    if (res.body !== undefined) {
+        if (res.get('content-type')) {
+            // use user defined content type, if exists
+            return;
+        }
+
+        if (Buffer.isBuffer(res.body)) {
+            res.type('application/octet-stream');
+        }
+    }
+}

test/WebJobs.Script.Tests/TestScripts/Node/functions.tests.js

@@ -22,6 +22,22 @@ describe('http', () => {
             res = response(context);
         });
 
+        it('setHeader', () => {
+            res.setHeader('TEST', 'val');
+            expect(res.headers.test).to.equal('val');
+        });
+
+        it('getHeader', () => {
+            res.setHeader('TEST', 'val');
+            expect(res.getHeader('TeSt')).to.equal('val');
+        });
+
+        it('removeHeader', () => {
+            res.setHeader('TEST', 'val');
+            res.removeHeader('teSt');
+            expect(res.getHeader('test')).to.be.undefined;
+        });
+
         it('status', () => {
             res.status(200);
             expect(res.statusCode).to.equal(200);
@@ -46,6 +62,19 @@ describe('http', () => {
             expect(context.isDone).to.be.true;
         });
 
+        it('sends buffer', () => {
+            res.send(new Buffer([0, 1]));
+            expect(Buffer.isBuffer(res.body)).to.be.true;
+            expect(res.get('content-type')).to.equal('application/octet-stream');
+        });
+
+        it('send maintains set type', () => {
+            res.send(new Buffer([0, 1]))
+                .type('image/png');
+            expect(Buffer.isBuffer(res.body)).to.be.true;
+            expect(res.get('content-type')).to.equal('image/png');
+        });
+
         it('json', () => {
             res.json('test');
             expect(res.body).to.equal('test');
@@ -54,13 +83,13 @@ describe('http', () => {
         });
 
         it('set', () => {
-            res.set('header', 'val');
+            res.set('Header', 'val');
             expect(res.headers.header).to.equal('val');
             expect(context.isDone).to.be.false;
         });
 
         it('header', () => {
-            res.header('header', 'val');
+            res.header('Header', 'val');
             expect(res.headers.header).to.equal('val');
             expect(context.isDone).to.be.false;
         });
@@ -77,6 +106,12 @@ describe('http', () => {
             expect(context.isDone).to.be.false;
         });
 
+        it('get upper', () => {
+            res.set('header', 'val');
+            expect(res.get('HEADER')).to.equal('val');
+            expect(context.isDone).to.be.false;
+        });
+
         it('raw', () => {
             res.raw('test');
             expect(res.body).to.equal('test');
@@ -100,8 +135,12 @@ describe('http', () => {
 
         it('get', () => {
             expect(req.get('test')).to.equal('val');
-        })
-    });    
+        });
+        
+        it('get upper', () => {
+            expect(req.get('TEST')).to.equal('val');
+        });
+    });
 });
 
 describe('functions', () => {
@@ -195,7 +234,6 @@ describe('functions', () => {
             });
 
             func(context, () => {});
-            
         });
 
         it('logs if promise and done', (done) => {