[pack] Fix keys APIs for functions without function.json (#7148)

Author: ankitkumarr

src/WebJobs.Script.WebHost/Controllers/KeysController.cs

@@ -31,15 +31,17 @@ public class KeysController : Controller
         private readonly IOptions<ScriptApplicationHostOptions> _applicationOptions;
         private readonly IFileSystem _fileSystem;
         private readonly IFunctionsSyncManager _functionsSyncManager;
+        private readonly IFunctionMetadataManager _functionMetadataManager;
         private readonly IScriptHostManager _hostManager;
 
-        public KeysController(IOptions<ScriptApplicationHostOptions> applicationOptions, ISecretManagerProvider secretManagerProvider, ILoggerFactory loggerFactory, IFileSystem fileSystem, IFunctionsSyncManager functionsSyncManager, IScriptHostManager hostManager)
+        public KeysController(IOptions<ScriptApplicationHostOptions> applicationOptions, ISecretManagerProvider secretManagerProvider, ILoggerFactory loggerFactory, IFileSystem fileSystem, IFunctionsSyncManager functionsSyncManager, IFunctionMetadataManager functionMetadataManager, IScriptHostManager hostManager)
         {
             _applicationOptions = applicationOptions;
             _secretManagerProvider = secretManagerProvider;
             _logger = loggerFactory.CreateLogger(ScriptConstants.LogCategoryKeysController);
             _fileSystem = fileSystem;
             _functionsSyncManager = functionsSyncManager;
+            _functionMetadataManager = functionMetadataManager;
             _hostManager = hostManager;
         }
 
@@ -285,9 +287,13 @@ internal bool IsBuiltInSystemKeyName(string keyName)
 
         private bool IsFunction(string functionName)
         {
-            string json = null;
             string functionPath = Path.Combine(_applicationOptions.Value.ScriptPath, functionName);
-            return Utility.TryReadFunctionConfig(functionPath, out json, _fileSystem);
+            if (Utility.TryReadFunctionConfig(functionPath, out _, _fileSystem))
+            {
+                return true;
+            }
+
+            return _functionMetadataManager.TryGetFunctionMetadata(functionName, out _);
         }
     }
 }

test/WebJobs.Script.Tests/Controllers/Admin/KeysControllerTests.cs

@@ -63,9 +63,19 @@ public KeysControllerTests()
 
             _functionsSyncManagerMock = new Mock<IFunctionsSyncManager>(MockBehavior.Strict);
             _functionsSyncManagerMock.Setup(p => p.TrySyncTriggersAsync(false)).ReturnsAsync(new SyncTriggersResult { Success = true });
+
             var hostManagerMock = new Mock<IScriptHostManager>(MockBehavior.Strict);
             hostManagerMock.SetupGet(p => p.State).Returns(ScriptHostState.Running);
-            _testController = new KeysController(new OptionsWrapper<ScriptApplicationHostOptions>(settings), new TestSecretManagerProvider(_secretsManagerMock.Object), new LoggerFactory(), fileSystem.Object, _functionsSyncManagerMock.Object, hostManagerMock.Object);
+
+            var metadataManagerMock = new Mock<IFunctionMetadataManager>(MockBehavior.Strict);
+            FunctionMetadata metadata = null;
+            metadataManagerMock.Setup(m => m.TryGetFunctionMetadata("FunctionWithoutFile", out metadata, false)).Returns(true);
+            metadataManagerMock.Setup(m => m.TryGetFunctionMetadata("TestFunction1", out metadata, false)).Returns(true);
+            // Function that has a physical file, but is loaded (safety net).
+            metadataManagerMock.Setup(m => m.TryGetFunctionMetadata("TestFunction2", out metadata, false)).Returns(false);
+            metadataManagerMock.Setup(m => m.TryGetFunctionMetadata("DNE", out metadata, false)).Returns(false);
+
+            _testController = new KeysController(new OptionsWrapper<ScriptApplicationHostOptions>(settings), new TestSecretManagerProvider(_secretsManagerMock.Object), new LoggerFactory(), fileSystem.Object, _functionsSyncManagerMock.Object, metadataManagerMock.Object, hostManagerMock.Object);
 
             var keys = new Dictionary<string, string>
             {
@@ -79,6 +89,12 @@ public KeysControllerTests()
             };
             _secretsManagerMock.Setup(p => p.GetFunctionSecretsAsync("TestFunction2", false)).ReturnsAsync(keys);
 
+            keys = new Dictionary<string, string>
+            {
+                { "key1", "secret1" }
+            };
+            _secretsManagerMock.Setup(p => p.GetFunctionSecretsAsync("FunctionWithoutFile", false)).ReturnsAsync(keys);
+
             _secretsManagerMock.Setup(p => p.GetFunctionSecretsAsync("DNE", false)).ReturnsAsync((IDictionary<string, string>)null);
 
             SetHttpContext();
@@ -95,6 +111,17 @@ public async Task GetKeys_ReturnsKeys()
             Assert.Equal("secret1", keys[0]["value"]);
         }
 
+        [Fact]
+        public async Task GetKeys_NoFileFunction_ReturnsKeys()
+        {
+            ObjectResult result = (ObjectResult)await _testController.Get("FunctionWithoutFile");
+
+            var content = (JObject)result.Value;
+            var keys = content["keys"];
+            Assert.Equal("key1", keys[0]["name"]);
+            Assert.Equal("secret1", keys[0]["value"]);
+        }
+
         [Fact]
         public async Task GetKeys_NotAFunction_ReturnsNotFound()
         {