Do not use cached options to create worker process (#5990)

Author: pragnagopa

src/WebJobs.Script/Workers/Rpc/IRpcWorkerProcessFactory.cs

@@ -5,6 +5,6 @@ namespace Microsoft.Azure.WebJobs.Script.Workers.Rpc
 {
     public interface IRpcWorkerProcessFactory
     {
-        IWorkerProcess Create(string workerId, string runtime, string scriptRootPath);
+        IWorkerProcess Create(string workerId, string runtime, string scriptRootPath, RpcWorkerConfig rpcWorkerConfig);
     }
 }

src/WebJobs.Script/Workers/Rpc/RpcWorkerChannelFactory.cs

@@ -40,7 +40,7 @@ public IRpcWorkerChannel Create(string scriptRootPath, string runtime, IMetricsL
             }
             string workerId = Guid.NewGuid().ToString();
             ILogger workerLogger = _loggerFactory.CreateLogger($"Worker.LanguageWorkerChannel.{runtime}.{workerId}");
-            IWorkerProcess rpcWorkerProcess = _rpcWorkerProcessFactory.Create(workerId, runtime, scriptRootPath);
+            IWorkerProcess rpcWorkerProcess = _rpcWorkerProcessFactory.Create(workerId, runtime, scriptRootPath, languageWorkerConfig);
             return new RpcWorkerChannel(
                          workerId,
                          _eventManager,

src/WebJobs.Script/Workers/Rpc/RpcWorkerProcessFactory.cs

@@ -1,28 +1,22 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
-using System;
-using System.Collections.Generic;
-using System.Linq;
 using Microsoft.Azure.WebJobs.Script.Abstractions;
 using Microsoft.Azure.WebJobs.Script.Eventing;
 using Microsoft.Extensions.Logging;
-using Microsoft.Extensions.Options;
 
 namespace Microsoft.Azure.WebJobs.Script.Workers.Rpc
 {
     internal class RpcWorkerProcessFactory : IRpcWorkerProcessFactory
     {
         private readonly IWorkerProcessFactory _workerProcessFactory;
-        private readonly IEnumerable<RpcWorkerConfig> _workerConfigs = null;
         private readonly IProcessRegistry _processRegistry;
         private readonly ILoggerFactory _loggerFactory = null;
         private readonly IScriptEventManager _eventManager = null;
         private readonly IRpcServer _rpcServer = null;
         private readonly IWorkerConsoleLogSource _consoleLogSource;
 
         public RpcWorkerProcessFactory(IRpcServer rpcServer,
-                                       IOptions<LanguageWorkerOptions> languageWorkerOptions,
                                        IScriptEventManager eventManager,
                                        ILoggerFactory loggerFactory,
                                        IWorkerProcessFactory defaultWorkerProcessFactory,
@@ -32,15 +26,13 @@ public RpcWorkerProcessFactory(IRpcServer rpcServer,
             _loggerFactory = loggerFactory;
             _eventManager = eventManager;
             _rpcServer = rpcServer;
-            _workerConfigs = languageWorkerOptions.Value.WorkerConfigs;
             _consoleLogSource = consoleLogSource;
             _workerProcessFactory = defaultWorkerProcessFactory;
             _processRegistry = processRegistry;
         }
 
-        public IWorkerProcess Create(string workerId, string runtime, string scriptRootPath)
+        public IWorkerProcess Create(string workerId, string runtime, string scriptRootPath, RpcWorkerConfig workerConfig)
         {
-            RpcWorkerConfig workerConfig = _workerConfigs.Where(c => c.Description.Language.Equals(runtime, StringComparison.OrdinalIgnoreCase)).FirstOrDefault();
             ILogger workerProcessLogger = _loggerFactory.CreateLogger($"Worker.rpcWorkerProcess.{runtime}.{workerId}");
             return new RpcWorkerProcess(runtime, workerId, scriptRootPath, _rpcServer.Uri, workerConfig.Arguments, _eventManager, _workerProcessFactory, _processRegistry, workerProcessLogger, _consoleLogSource);
         }

test/WebJobs.Script.Tests/Workers/Rpc/WebHostRpcWorkerChannelManagerTests.cs

@@ -64,7 +64,7 @@ public WebHostRpcWorkerChannelManagerTests()
             _workerOptionsMonitor = TestHelpers.CreateOptionsMonitor(_languageWorkerOptions);
 
             _rpcWorkerProcessFactory = new Mock<IRpcWorkerProcessFactory>();
-            _rpcWorkerProcessFactory.Setup(m => m.Create(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>())).Returns(_rpcWorkerProcess.Object);
+            _rpcWorkerProcessFactory.Setup(m => m.Create(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<RpcWorkerConfig>())).Returns(_rpcWorkerProcess.Object);
 
             _testLogger = new TestLogger("WebHostLanguageWorkerChannelManagerTests");
             _rpcWorkerChannelFactory = new TestRpcWorkerChannelFactory(_eventManager, _testLogger, _scriptRootPath);